Refactor Hooks to no longer rely on global state and improve type safety
Closed, DuplicatePublic
Actions

Assigned To

None

Authored By

	daniel
	Jan 5 2017, 4:41 PM

Description

Hook handlers are currently registered and triggered via global variables and static functions. To allow hook handlers to be injected, and be called in a typesafe way, some refactoring is required, see subtasks.

Related Objects
Search...

Status	Assigned	Task
Duplicate	None	T154673 Refactor Hooks to no longer rely on global state and improve type safety
Invalid	None	T154674 Introduce HookRunner, a wrapper for hook handlers for a specific event.
Invalid	None	T154675 Introduce a listener interface for LinkRenderer hooks

Event Timeline

daniel created this task.Jan 5 2017, 4:41 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 5 2017, 4:41 PM

daniel added a project: Architecture.Jan 5 2017, 4:42 PM

daniel created subtask T154674: Introduce HookRunner, a wrapper for hook handlers for a specific event..Jan 5 2017, 4:44 PM

daniel created subtask T154677: Turn static Hooks class into HookManager service.Jan 5 2017, 4:55 PM

daniel moved this task from Inbox to Project on the User-Daniel board.Jan 5 2017, 6:55 PM

SamanthaNguyen moved this task from Unsorted to Needs refactor on the Technical-Debt board.Jan 7 2017, 11:41 PM

Tgr subscribed.Feb 4 2017, 7:13 AM

Krinkle edited projects, added TechCom; removed Architecture.Jan 4 2018, 12:32 AM

I understand the global state issue, but not sure I understand the type safety issue... ie, would this aim towards allowing static analysis to confirm that hooks have the right signature? Or something more general?

SamanthaNguyen subscribed.Jan 26 2018, 1:14 AM

daniel updated the task description. (Show Details)Mar 7 2018, 9:35 PM

daniel mentioned this in T171515: Hooks system should support MediaWiki services.

daniel moved this task from Inbox to Backlog on the TechCom board.Mar 7 2018, 9:42 PM

Ladsgroup subscribed.Dec 12 2018, 5:57 PM

Krinkle closed this task as a duplicate of T212482: RFC: Evolve hook system to support "filters" and "actions" only.Dec 21 2018, 2:45 AM

Krinkle removed a subtask: T154677: Turn static Hooks class into HookManager service.

daniel closed subtask T154674: Introduce HookRunner, a wrapper for hook handlers for a specific event. as Invalid.Apr 8 2020, 8:16 AM