Page MenuHomePhabricator

Mobile mentions should link to mobile view and not desktop view
Closed, DuplicatePublic

Description

Steps to reproduce:

  1. Wait for a mention from user on some wiki
  2. Go to that wiki on mobile phone browser and login
  3. Tap the bell icon
  4. Tap that new unread mention

Expected behavior:
Link leads to mobile view page.

Current behavior:
Link opens desktop view page instead.

Related: T107108

Developer notes

The issue is because content in API requests do not apply MobileContext::getMobileUrl

Event Timeline

Dvorapa created this task.Jan 6 2017, 6:50 AM
Dvorapa updated the task description. (Show Details)
Dvorapa renamed this task from Mobile mentions should lead to mobile view and not desktop view to Mobile mentions should link to mobile view and not desktop view.Jan 6 2017, 6:53 AM
phuedx added a comment.Jan 6 2017, 9:08 AM

@Dvorapa: Thanks for the bug report!


While the experience isn't broken, it's not the most performant: tapping a notification on en.m. the UA will navigate to en., Varnish will issue a 302 to en.m., and the UA will navigate to the specified location. That's two round trips to start reading a notification!

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJan 6 2017, 9:09 AM
Jdlrobson updated the task description. (Show Details)Jan 9 2017, 12:18 AM
Trizek-WMF triaged this task as High priority.Jan 24 2017, 6:47 PM
Trizek-WMF added a subscriber: Trizek-WMF.

I've tested it:

  1. I'm browsing https://en.m.wikipedia.org (or any mobile version)
  2. I click on a notification on that website
  3. I'm redirected to https://en.wikipedia.org/wiki/User_talk:Trizek_(WMF)

Links should redirect to mobile version.

Note MobileContext in MobileFrontend does provide a method getMobileUrl for obtaining the '.m' url. I don't see how to get round this except altering the logic of getFullUrl or Echo running this method on notifications before rendering.

Jdlrobson changed the task status from Open to Stalled.Jun 15 2017, 9:27 PM

Stalled on T156847

Jdlrobson added a project: MobileFrontend.
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Backlog to Tracking on the MobileFrontend board.
Restricted Application removed a subscriber: Liuxinyu970226. · View Herald TranscriptJul 13 2017, 5:40 PM