Page MenuHomePhabricator

FileAnnotations prototype: No indication on how to edit/undo the annotation that was just addded
Closed, DeclinedPublic

Event Timeline

We have a couple of options on how to do this. We'll probably have to come to a standardized way of attaching any sort of action to a card. We have some examples in the wild, like Hovercards, with its setting ButtonWidget (with icon only), and MessageDialog in OOUI. A floating green round button is pretty much an alien :)

HovercardsMessageDialogRound green alien
Screen Shot 2017-01-09 at 2.49.32 PM.png (213×328 px, 38 KB)
Screen Shot 2017-01-09 at 2.48.59 PM.png (152×322 px, 16 KB)
Screen Shot 2017-01-09 at 2.50.16 PM.png (168×216 px, 98 KB)

Between the Hovercards and the MessageDialog options, the latter might be clearer. We are already using a similar pattern on the Wikidata item annotations. Also, I fear that the Hovercards way might not make it clear what the user is editing (is it the Wikidata description, or the annotation itself. better placement will improve understanding, but I am not sure where that would be).

HovercardsMessageDialog
hovercards.png (320×200 px, 95 KB)
messagedialog.png (355×200 px, 96 KB)

Between the Hovercards and the MessageDialog options, the latter might be clearer. We are already using a similar pattern on the Wikidata item annotations. Also, I fear that the Hovercards way might not make it clear what the user is editing (is it the Wikidata description, or the annotation itself. better placement will improve understanding, but I am not sure where that would be).

I think it makes sense to make editing to be less prominent than the main actions to access information. Maybe using just the icon may be enough. In terms of placement, at the right of the title (next to the right edge of the card) could work well in terms of feeling as a global but non prominent action.

Ramsey-WMF changed the task status from Open to Stalled.Nov 17 2017, 5:14 PM
Ramsey-WMF lowered the priority of this task from Medium to Lowest.
Ramsey-WMF added a project: SDC General.
Ramsey-WMF subscribed.

Since the 2016/2017 FileAnnotations prototype work is now quite outdated and both Wikidata and Commons have new features and design plans (like moving new features to Vue.js on Commons), and the extension is not actively under development, the best thing to do is close these tasks and create new ones when/if there's a team available to pick up development on this feature.