| Pginer-WMF | |
| Jan 6 2017, 10:03 AM |
| F5358279: Screen Shot 2017-01-25 at 3.04.58 PM.png | |
| Jan 25 2017, 11:06 PM |
| F5241024: flow-log-in-gap.png | |
| Jan 6 2017, 10:03 AM |
| F5241026: flow-login-nogap.png | |
| Jan 6 2017, 10:03 AM |
When users try to post a message in flow without logging-in a message is shown to remind them they are not logged-in. The idea was to present it as part of the input area, but it currently shows a gap between both:
It should look like this instead:
I'm quite sure it used to look like the later, but some regression may have happened at some point.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| CanNotEditWidget: Hide properly when not active | mediawiki/extensions/Flow | master | +2 -4 |
Hmm, this is because the canNotEditWidget (for the message saying you cannot edit what you're trying to edit because you're blocked or whatever) has a height of 5px even when hidden. I'm confused as to why, because there seem to be enough line-height: 0 rules to prevent this from happening.
Change 330999 had a related patch set uploaded (by Catrope):
CanNotEditWidget: Hide properly when not active
There was related task T116573 closed, as I thought the message was not intended to be connected as that's not a pattern we follow anywhere else. And it wasn't connected any more (not done by myself!).
