Page MenuHomePhabricator

Paypal notifications with negative transaction fee throw exceptions
Closed, ResolvedPublic

Description

When a PayPal notification with a negative transaction fee (meaning a refund, see https://developer.paypal.com/docs/classic/ipn/integration-guide/IPNandPDTVariables/) comes in, the Euro class throws an exception while constructing the PayPalNotificationRequest because the Euro only allows positive values.

Event Timeline

Restricted Application added a project: TCB-Team. · View Herald TranscriptJan 6 2017, 5:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@JeroenDeDauw what's the best solution here? The notification request will probably be dropped by the use case, but the decision if a use case should be dropped should stay inside the use case IMHO, so the request needs to be valid.

gabriel-wmde renamed this task from Paypal notfications with negative transaction throw exceptions to Paypal notfications with negative transaction fee throw exceptions.Jan 6 2017, 5:13 PM
JEumerus renamed this task from Paypal notfications with negative transaction fee throw exceptions to Paypal notifications with negative transaction fee throw exceptions.Jan 6 2017, 5:19 PM
gabriel-wmde closed this task as Resolved.Feb 3 2017, 10:30 AM
gabriel-wmde claimed this task.
gabriel-wmde moved this task from Backlog to Done on the WMDE-FUN-Team board.

Done in the PR and deployed.