Page MenuHomePhabricator

Show helpful message upon tapping Revert notification.
Closed, ResolvedPublic3 Estimated Story Points

Description

Our Revert notification shall have an action button that says "More info". Tapping this button will do the following:

  • Launch the app and display the article that is the subject of the notification.
  • Immediately display a popup dialog with some reassuring information about why the edit might have been reverted.

Mock:
https://wikimedia.invisionapp.com/share/W79AYFHTK#/screens/211514138

Event Timeline

Change 333685 had a related patch set uploaded (by Dbrant):
Make revert notification lead to the original page, with help dialog.

https://gerrit.wikimedia.org/r/333685

Change 333685 merged by jenkins-bot:
Make revert notification lead to the original page, with help dialog.

https://gerrit.wikimedia.org/r/333685

Change 334397 had a related patch set uploaded (by Mholloway):
Pass the wiki from which notifications came to NotificationPresenter

https://gerrit.wikimedia.org/r/334397

Change 334397 abandoned by Mholloway:
Pass the wiki from which notifications came to NotificationPresenter

Reason:
needs work

https://gerrit.wikimedia.org/r/334397

I don't understand the description well enough to test this. If anyone does know how to test this, please post some screencaps or video, and a list of steps I can use to test the functionality all by myself, and I will try to recreate the scenario.

@Nicholas.tsg:

  1. Launch the app
  2. Go to the Wikipedia:Wikidata/Wikidata Sandbox article
  3. Edit the description
  4. Go to the Wikipedia:Wikidata/Wikidata Sandbox article on a computer
  5. Tap the the Wikidata Sandbox link
  6. Tap view history
  7. Tap undo next to your edit made in app
  8. Enter "test" under summary
  9. Press save page
  10. Wait a few minutes and a notification should appear on the phone
  11. Tap the notification

Testing on Samsung-SM-JI20A Galaxy Express 3 (Android 6.0.1) and Wikipedia app 2.5.188-alpha-2017-02-14. This works as expected according to the @Niedzielski steps as although it took many minutes I did receive a notification on the device and tapping it lead to this dialog:

T154787 Reverted edit.png (800×480 px, 49 KB)