Page MenuHomePhabricator
Create Task
Maniphest T154804

TypeError in parsoid gallery module
Closed, ResolvedPublic
Actions

Description

There's a low-rate error logs in RESTBase logs related to some crash in Parsoid code. Log example:

Request URI: /ca.wikipedia.org/v1/transform/html/to/wikitext/Pisa_daurada
Error stack:

Cannot read property 'caption' of undefined
TypeError: Cannot read property 'caption' of undefined
    at Object.<anonymous> (/srv/deployment/parsoid/deploy-cache/revs/465f9c47ebefadc71a5f38b19e57e3ea820d3bc3/src/lib/ext/Gallery/index.js:308:24)

Unfortunately we don't know what content was provided in the transform POST request.

Related Objects

Event Timeline

• Pchelolo created this task.Jan 6 2017, 9:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 6 2017, 9:29 PM
gerritbot subscribed.Jan 6 2017, 10:16 PM

Change 331081 had a related patch set uploaded (by Arlolra):
T154804: Serialize gallery without attrs in data-mw

https://gerrit.wikimedia.org/r/331081

gerritbot added a project: Patch-For-Review.Jan 6 2017, 10:16 PM
Arlolra triaged this task as Medium priority.Jan 6 2017, 10:16 PM
gerritbot added a comment.Jan 6 2017, 10:28 PM

Change 331081 merged by jenkins-bot:
T154804: Serialize gallery without attrs in data-mw

https://gerrit.wikimedia.org/r/331081

Arlolra closed this task as Resolved.Jan 6 2017, 10:32 PM
Arlolra added a comment.Jan 6 2017, 11:32 PM

Unfortunately we don't know what content was provided in the transform POST request.

@Pchelolo Btw, that page was created with ContentTranslation so maybe something to do with translating a gallery? Just a thought.

• Pchelolo added a comment.Jan 6 2017, 11:33 PM

@Arlolra No idea to be honest, I lack context here. Anyway, let's hope this doesn't occur any more.

Stashbot mentioned this in T58846: Review failing sanitizer bugs.Jan 24 2017, 6:58 PM
Stashbot subscribed.

Mentioned in SAL (#wikimedia-operations) [2017-01-24T18:58:07Z] <arlolra> Updated Parsoid to version d000fdb4 (T58846, T154804, T152633)

Stashbot mentioned this in T152633: TypeError: Cannot read property 'length' of undefined.Jan 24 2017, 6:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL