No longer getting Revert notifications
Closed, ResolvedPublic
Actions

Description

On Wikidata, I no longer seem to be able to get "revert" notifications via Echo (i.e. if I make a change to an item's description, and someone reverts it, I no longer get a notification. This is for testing of our Android app that will soon allow editing of descriptions).

Details

	Subject	Repo	Branch	Lines +/-
	Pass $undidRevId as a parameter to SubmitEntityAction::attemptSave	mediawiki/extensions/Wikibase	master	+10 -8
	Pass undone revision id for further proccessing	mediawiki/extensions/Wikibase	master	+10 -1

Customize query in gerrit

Related Objects

Mentioned In: T153570: Notify users when undoing multiple revisions
Mentioned Here: rECHO56abaaf43493: Get undone revision id from hook param instead of request
T153567: Reverts with the API don't notify users anymore

Event Timeline

Dbrant created this task.Jan 6 2017, 9:52 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 6 2017, 9:52 PM

matej_suchanek added a project: Notifications.Jan 7 2017, 8:13 AM

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJan 7 2017, 8:13 AM

Do you have an example of revert which didn't create a notification?

Sure, it seems like it's any revision made after 01/05, including:

If these reverts did not trigger a notification, then it seems to be a Regression from rECHO56abaaf434938e1f5c218711f9225ffda28560e5 which fixed T153567. I think it's Wikibase that should be updated (propably inside repo/includes/Actions/SubmitEntityAction.php).

• Mholloway subscribed.Jan 7 2017, 3:14 PM

Change 331155 had a related patch set uploaded (by Matěj Suchánek):
Pass undone revision id for further proccessing

https://gerrit.wikimedia.org/r/331155

gerritbot added a project: Patch-For-Review.Jan 7 2017, 3:37 PM

matej_suchanek added subscribers: Cenarium, Lydia_Pintscher.Jan 7 2017, 3:38 PM

Scott_WUaS subscribed.Jan 7 2017, 7:33 PM

Lea_Lacroix_WMDE added a subscriber: Trizek-WMF.Jan 9 2017, 9:21 AM

Lea_Lacroix_WMDE subscribed.

• Niedzielski subscribed.Jan 9 2017, 6:12 PM

Change 331466 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
This is mostly for readability of the code. Before it was not obvious that the attemptSave() method was only called for undo operations. Now this is much more obvious.

https://gerrit.wikimedia.org/r/331466

Change 331155 merged by jenkins-bot:
Pass undone revision id for further proccessing

https://gerrit.wikimedia.org/r/331155

matej_suchanek mentioned this in T153570: Notify users when undoing multiple revisions.Jan 11 2017, 6:49 PM

Change 331466 merged by jenkins-bot:
Pass $undidRevId as a parameter to SubmitEntityAction::attemptSave

https://gerrit.wikimedia.org/r/331466