Page MenuHomePhabricator
Create Task
Maniphest T154848

GooglePlaces tests failing due to missing files located in sub repo
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

GooglePlaces has a sub repo google-places, which is not known by the test framework and such this gives error when tests are running:

15:15:47 There was 1 failure:
15:15:47 
15:15:47 1) AutoLoaderTest::testAutoLoadConfig
15:15:47 Failed asserting that two arrays are equal.
15:15:47 --- Expected
15:15:47 +++ Actual
15:15:47 @@ @@
15:15:47      'GooglePlacesCache' => '/srv/jenkins-workspace/worksp...he.php'
15:15:47 -    'Mills\GooglePlaces\googlePlaces' => '/srv/jenkins-workspace/workspace/mwext-testextension-hhvm-composer@2/src/extensions/GooglePlaces/lib/google-places/src/mills/google-places/googlePlaces.php'
15:15:47 +    'Mills\GooglePlaces\googlePlaces' => '[file '/srv/jenkins-workspace/workspace/mwext-testextension-hhvm-composer@2/src/extensions/GooglePlaces/lib/google-places/src/mills/google-places/googlePlaces.php' does not exist]'
15:15:47      'TestAutoloadedClass' => '/srv/jenkins-workspace/worksp...ss.php'
15:15:47  )
15:15:47 
15:15:47 /srv/jenkins-workspace/workspace/mwext-testextension-hhvm-composer@2/src/tests/phpunit/structure/AutoLoaderTest.php:35
15:15:47 /srv/jenkins-workspace/workspace/mwext-testextension-hhvm-composer@2/src/tests/phpunit/MediaWikiTestCase.php:399
15:15:47 /srv/jenkins-workspace/workspace/mwext-testextension-hhvm-composer@2/src/maintenance/doMaintenance.php:111

Details

SubjectRepoBranchLines +/-
Make some extension votingintegration/configmaster+6 -11
Add missing class to the autoloadermediawiki/extensions/GooglePlacesmaster+2 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Umherirrender created this task.Jan 7 2017, 3:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 7 2017, 3:43 PM
Umherirrender added a comment.Jan 7 2017, 3:45 PM

One solution is to bundle the files with the extension, makes install easier. See T154806 for a discussion about this problem on another repo

Umherirrender added a parent task: T134090: fix or mark as inactive extensions currently failing CI.Jan 19 2017, 8:46 PM
Liuxinyu970226 edited projects, added MediaWiki-extensions-Other; removed MediaWiki-extensions-General.Feb 25 2017, 12:33 PM
Liuxinyu970226 added a subscriber: tosfos.
Krinkle moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board.Jul 7 2017, 5:10 AM
hashar added a subtask: T130966: generalize extension submodule handling.Jul 18 2017, 1:02 PM
hashar mentioned this in T130966: generalize extension submodule handling.Jul 18 2017, 1:11 PM
hashar closed subtask T130966: generalize extension submodule handling as Resolved.Aug 2 2017, 1:51 PM
hashar subscribed.Aug 2 2017, 2:01 PM

Submodules are now process (T130966). It now fails with

13:59:21 1) AutoLoaderTest::testAutoLoadConfig
13:59:21 Failed asserting that two arrays are equal.
13:59:21 --- Expected
13:59:21 +++ Actual
13:59:21 @@ @@
13:59:21 'TestAutoloadedClass' => '/home/jenkins/workspace/mwext...ss.php'
13:59:21 + 'Mills\GooglePlaces\googlePlacesCallType' => '/home/jenkins/workspace/mwext...es.php'
13:59:21 )
13:59:21

gerritbot subscribed.Aug 2 2017, 2:05 PM

Change 369655 had a related patch set uploaded (by Paladox; owner: Paladox):
[mediawiki/extensions/GooglePlaces@master] Add missing class to the autoloader

https://gerrit.wikimedia.org/r/369655

gerritbot added a project: Patch-For-Review.Aug 2 2017, 2:05 PM
Paladox subscribed.Aug 2 2017, 2:05 PM
gerritbot added a comment.Aug 2 2017, 2:11 PM

Change 369655 merged by jenkins-bot:
[mediawiki/extensions/GooglePlaces@master] Add missing class to the autoloader

https://gerrit.wikimedia.org/r/369655

Paladox closed this task as Resolved.Aug 2 2017, 2:13 PM
Paladox claimed this task.
gerritbot added a comment.Aug 2 2017, 2:14 PM

Change 369659 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Make some extension voting

https://gerrit.wikimedia.org/r/369659

gerritbot added a comment.Aug 2 2017, 2:17 PM

Change 369659 merged by jenkins-bot:
[integration/config@master] Make some extension voting

https://gerrit.wikimedia.org/r/369659

Umherirrender added a project: Wikimedia-production-error (ARCHIVED -- Shared Build Failure).Apr 13 2018, 7:19 PM
Umherirrender removed a parent task: T134090: fix or mark as inactive extensions currently failing CI.
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL