Page MenuHomePhabricator

Undefined i18n message in aftv5: articleFeedbackv5-view-activity-error
Open, Needs TriagePublic

Description

https://github.com/wikimedia/mediawiki-extensions-ArticleFeedbackv5/blob/master/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.js#L866

This attempts to return an i18n message in an error, however the message is non-existent.

jquery.articleFeedbackv5.special.js
'error': function ( data ) {
	// FIXME this messages isn't defined
	$( location ).text( mw.msg( 'articleFeedbackv5-view-activity-error' ) );
}

Event Timeline

Restricted Application added subscribers: TerraCodes, Aklapper. · View Herald TranscriptJan 8 2017, 10:50 PM

What should it say?

TerraCodes updated the task description. (Show Details)Apr 14 2017, 8:47 PM

I've checked and this issue still exist. What should be the value of articleFeedbackv5-view-activity-error in en.json as already asked by @TerraCodes . If the extension authors and/or maintainers can say what articleFeedbackv5-view-activity-error should be, then that can be added to en.json and documented in qqq.json.

Kizule added a subscriber: Kizule.Feb 24 2018, 1:49 PM
In T154883#3926165, @D3r1ck01 wrote:

I've checked and this issue still exist. What should be the value of articleFeedbackv5-view-activity-error in en.json as already asked by @TerraCodes . If the extension authors and/or maintainers can say what articleFeedbackv5-view-activity-error should be, then that can be added to en.json and documented in qqq.json.

Hello @D3r1ck01 From your comment, how can I reach out to the extension authors/maintainers of this project? I would love to work on this issue,

how can I reach out to the extension authors/maintainers of this project?

@Didicodes: "Authors": People who wrote some code many years ago will often not be around anymore (or maybe not care anymore).
"Maintainers": In theory by commenting and asking specific questions in the task. However, people might be busy doing other things (especially if they are volunteers). Clicking ArticleFeedbackv5 under "Tags" above usually provides further information and links.

Didicodes added a comment.EditedMar 17 2019, 2:02 PM

Oh great. I clicked on ArticleFeedbackv5 under Tags and I saw all the members of the project.

They are currently 9 members on the project, what if I mention them here on this task so anybody who sees it first can respond. That is allowed right? @Aklapper

Please don't mass-subscribe people. It's up to every individual what they decide to follow.

Okay. I will reach out to them individually.

The "nonexistent message" was introduced in 9ac9a637792e97d903125074b683272fdd489274 in February 2012, replacing a prior console.log call which'd log the "helpful" string "error" and nothing else to the browser's JS console. The FIXME comment about a missing i18n message was added in early March 2012 in 8087227e394acb351f6cbad8dce4a2bc6932f76e.
Personally I'd really prefer if the error message would provide more context than just "Error" but even that is better than attempting to call a nonexistent message.