Page MenuHomePhabricator
Create Task
Maniphest T154924

Remove jshint from V+1 as well as V+2 pipes for repos that use eslint now
Closed, ResolvedPublic
Actions

Description

At least WikiEditor, probably quite a few others. When we switched we removed all the jshint over-rides, so those will fail.

Details

SubjectRepoBranchLines +/-
Clean out jsonlint/jshintintegration/configmaster+29 -1 K
[TemplateSandbox] remove jshint, has been moved to eslintintegration/configmaster+0 -1
[Score] remove jshint, has been moved to eslintintegration/configmaster+0 -1
Customize query in gerrit

Related Objects

Event Timeline

Jdforrester-WMF created this task.Jan 9 2017, 7:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 9 2017, 7:29 PM
Paladox added a subscriber: Paladox.Jan 9 2017, 7:31 PM
DatGuy added a subscriber: DatGuy.Jan 9 2017, 8:08 PM
hashar closed this task as a duplicate of T149201: Remove jshint and jscs in favor of eslint (linting and code style) in Reading Web code.Jan 20 2017, 11:49 AM
Jdforrester-WMF mentioned this in T149201: Remove jshint and jscs in favor of eslint (linting and code style) in Reading Web code.Jan 26 2017, 2:37 PM
Jdforrester-WMF reopened this task as Open.Apr 15 2017, 2:08 AM

Still not done.

Paladox added a comment.Apr 15 2017, 7:02 PM

If we do this. Non whitelisted users will not have any js test run.

Jdforrester-WMF added a comment.Apr 17 2017, 5:54 PM
In T154924#3184686, @Paladox wrote:

If we do this. Non whitelisted users will not have any js test run.

Indeed.

gerritbot added a subscriber: gerritbot.Apr 24 2017, 8:27 AM

Change 349883 had a related patch set uploaded (by Hashar):
[integration/config@master] [Score] remove jshint, has been moved to eslint

https://gerrit.wikimedia.org/r/349883

gerritbot added a project: Patch-For-Review.Apr 24 2017, 8:27 AM

Change 349884 had a related patch set uploaded (by Hashar):
[integration/config@master] [TemplateSandbox] remove jshint, has been moved to eslint

https://gerrit.wikimedia.org/r/349884

gerritbot added a comment.Apr 24 2017, 8:34 AM

Change 349883 merged by jenkins-bot:
[integration/config@master] [Score] remove jshint, has been moved to eslint

https://gerrit.wikimedia.org/r/349883

gerritbot added a comment.Apr 24 2017, 8:34 AM

Change 349884 merged by jenkins-bot:
[integration/config@master] [TemplateSandbox] remove jshint, has been moved to eslint

https://gerrit.wikimedia.org/r/349884

gerritbot added a comment.Apr 24 2017, 8:43 AM

Change 349439 had a related patch set uploaded (by Hashar):
[integration/config@master] Clean out jsonlint/jshint

https://gerrit.wikimedia.org/r/349439

gerritbot added a comment.Apr 24 2017, 8:51 AM

Change 349439 merged by jenkins-bot:
[integration/config@master] Clean out jsonlint/jshint

https://gerrit.wikimedia.org/r/349439

hashar added a subscriber: hashar.Apr 24 2017, 8:53 AM

For most repositories, I have removed the jshint job that ran an outdated version of jshint. Most repos are thus now just invoking "npm test".

hashar closed this task as Resolved.Apr 25 2017, 8:40 AM
hashar claimed this task.

The Jenkins job that runs jshint has been removed from all the repositories. They now solely run npm test and whatever developers have defined in their repo.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL