Page MenuHomePhabricator
Create Task
Maniphest T154960

ServiceWiringFiles not defined for m.wikipedia.org when trying to load an extension
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Uncaught exception 'ConfigException' with message 'GlobalVarConfig::get: undefined option: 'ServiceWiringFiles'' in /srv/mediawiki/php-1.29.0-w
mf.7/includes/config/GlobalVarConfig.php:53

Fatal error: Uncaught exception 'ConfigException' with message 'GlobalVarConfig::get: undefined option: 'ServiceWiringFiles'' in /srv/mediawiki/php-1.29.0-wmf.7/includes/config/GlobalVarConfig.php:53
Stack trace:
#0 /srv/mediawiki/php-1.29.0-wmf.7/includes/MediaWikiServices.php(245): GlobalVarConfig->get()
#1 /srv/mediawiki/php-1.29.0-wmf.7/includes/MediaWikiServices.php(104): MediaWiki\MediaWikiServices::newInstance()
#2 /srv/mediawiki/php-1.29.0-wmf.7/includes/registration/ExtensionRegistry.php(97): MediaWiki\MediaWikiServices::getInstance()
#3 /srv/mediawiki/php-1.29.0-wmf.7/includes/registration/ExtensionRegistry.php(87): ExtensionRegistry->__construct()
#4 /srv/mediawiki/php-1.29.0-wmf.7/includes/GlobalFunctions.php(116): ExtensionRegistry::getInstance()
#5 /srv/mediawiki/wmf-config/CommonSettings.php(468): wfLoadExtension()
#6 /srv/mediawiki/php-1.29.0-wmf.7/LocalSettings.php(3): include()
#7 /srv/mediawiki/php-1.29.0-wmf.7/includes/WebStart.php(124): include()
#8 /srv/mediawiki/multiversion/MWVersion.php(21): include()
#9 /srv/mediawiki/w/mobilelanding.php(5): getMediaWiki()
#10 {main}

This causes m.wikipedia.org to be down, but not en.m.wikipedia, fr.m.wikipedia,org, etc.

According logstash, error occured just after these two deployments:

23:34 reedy@tin: Synchronized wmf-config/extension-list: More to extension.json (duration: 00m 40s)
23:29 demon@tin: Synchronized multiversion: Final batch of MWVersion cleanup (in song form) (duration: 00m 56s)

The error occurs (see #5 /srv/mediawiki/wmf-config/CommonSettings.php(468): wfLoadExtension()) when trying to load the PagedTiffHandler extension:

CommonSettings.php:467-469
if ( $wmgUsePagedTiffHandler ) {
    wfLoadExtension( 'PagedTiffHandler' );
}

As this is the first extension to load, best to focus on:

/srv/mediawiki/php-1.29.0-wmf.7/includes/registration/ExtensionRegistry.php(87): ExtensionRegistry->__construct()

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
registration: Don't initialize MWServices super earlyLegoktmmediawiki/coreREL1_27+9 -18
registration: Don't initialize MWServices super earlyReedymediawiki/corewmf/1.29.0-wmf.7+9 -17
registration: Don't initialize MWServices super earlyLegoktmmediawiki/coremaster+9 -17
Customize query in gerrit

Related Objects
Search...

Event Timeline

Dereckson created this task.Jan 10 2017, 1:25 AM
Restricted Application added subscribers: Jay8g, TerraCodes, Aklapper. · View Herald TranscriptJan 10 2017, 1:25 AM
Reedy added a project: Mobile.Jan 10 2017, 1:26 AM
Enterprisey subscribed.Jan 10 2017, 1:26 AM
Dereckson added a subscriber: • demon.Jan 10 2017, 1:27 AM
Reedy added a comment.Jan 10 2017, 1:34 AM

https://gerrit.wikimedia.org/r/#/c/309363/ seems to be the problem

Dereckson renamed this task from ServiceWiringFiles not defined for m.wikipedia.org to ServiceWiringFiles not defined for m.wikipedia.org when trying to load PagedTiffHandler extension.Jan 10 2017, 1:35 AM
Dereckson lowered the priority of this task from Unbreak Now! to Medium.
Dereckson updated the task description. (Show Details)
• demon added a comment.Jan 10 2017, 1:37 AM

What makes you say that? I see wfLoadExtension() in there which is more suspect imho.... All we did in 309363 is move some code, it's functionally identical.

Dereckson renamed this task from ServiceWiringFiles not defined for m.wikipedia.org when trying to load PagedTiffHandler extension to ServiceWiringFiles not defined for m.wikipedia.org when trying to load an extension.Jan 10 2017, 2:04 AM
Dereckson updated the task description. (Show Details)
Reedy added a comment.Jan 10 2017, 3:45 AM
In T154960#2929665, @demon wrote:

What makes you say that? I see wfLoadExtension() in there which is more suspect imho.... All we did in 309363 is move some code, it's functionally identical.

Reverting your patch fixed it though...

• demon added a comment.Jan 10 2017, 6:29 PM
In T154960#2929843, @Reedy wrote:
In T154960#2929665, @demon wrote:

What makes you say that? I see wfLoadExtension() in there which is more suspect imho.... All we did in 309363 is move some code, it's functionally identical.

Reverting your patch fixed it though...

Per our in-person discussion: pretty sure this just exposed something that was already existing.

Legoktm subscribed.Jan 10 2017, 6:44 PM

I think ExtensionRegistry trying to initialize MediaWikiServices that early on is a bad idea. I can work on a patch for that.

gerritbot subscribed.Jan 10 2017, 6:49 PM

Change 331518 had a related patch set uploaded (by Legoktm):
registration: Don't initialize MWServices super early

https://gerrit.wikimedia.org/r/331518

gerritbot added a project: Patch-For-Review.Jan 10 2017, 6:49 PM
Paladox subscribed.Jan 10 2017, 6:52 PM
gerritbot added a comment.Jan 10 2017, 7:19 PM

Change 331518 merged by jenkins-bot:
registration: Don't initialize MWServices super early

https://gerrit.wikimedia.org/r/331518

gerritbot added a comment.Jan 10 2017, 7:32 PM

Change 331522 had a related patch set uploaded (by Reedy):
registration: Don't initialize MWServices super early

https://gerrit.wikimedia.org/r/331522

ReleaseTaggerBot added projects: MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)).Jan 10 2017, 8:00 PM
Reedy created subtask T155043: "Don't initialize MWServices super early" causes test failure on .7.Jan 10 2017, 8:03 PM
Reedy removed a project: Mobile.
gerritbot added a comment.Jan 10 2017, 9:24 PM

Change 331522 merged by Reedy:
registration: Don't initialize MWServices super early

https://gerrit.wikimedia.org/r/331522

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)).Jan 10 2017, 10:00 PM
MaxSem closed this task as Resolved.Jan 11 2017, 11:04 PM
MaxSem assigned this task to Legoktm.
Krinkle closed subtask T155043: "Don't initialize MWServices super early" causes test failure on .7 as Resolved.Mar 20 2018, 2:39 AM
gerritbot added a comment.Aug 14 2018, 9:51 PM

Change 452838 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@REL1_27] registration: Don't initialize MWServices super early

https://gerrit.wikimedia.org/r/452838

gerritbot removed a project: MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)).Aug 14 2018, 9:51 PM
gerritbot added a comment.Aug 14 2018, 10:17 PM

Change 452838 merged by jenkins-bot:
[mediawiki/core@REL1_27] registration: Don't initialize MWServices super early

https://gerrit.wikimedia.org/r/452838

Reedy removed a project: Patch-For-Review.May 17 2019, 9:47 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits