Page MenuHomePhabricator

Error upon attempted edit
Closed, DuplicatePublic1 Estimated Story Points

Description

Neil Quinn reports that the current beta gives an "Edit failed!" error on every attempted edit. I witnessed this on his phone but can't reproduce it.

Device: Moto Z Play Droid
Android version: Android 6.0.1
App version: 2.4.184-beta-2016-12-14.

Event Timeline

@Neil_P._Quinn_WMF If you're comfortable letting one of us hook up to your phone for a minute to get a stack trace, that would make it easy to get to the bottom of this.

@Mholloway, I'm willing to let you do that. I'll be at the summit today and tomorrow, so feel free to find me any time.

Mholloway renamed this task from Crash upon attempted edit to Error upon attempted edit.Jan 10 2017, 7:50 PM

Neil, do you have 2FA set on your wiki login(s) by any chance?

No, I haven't set that up on any of my accounts yet.

Voila:

01-10 15:46:04.215 21265-21265/? W/org.wikipedia.edit.EditSectionActivity$4$1: failure():346: 
  java.lang.RuntimeException: Invalid CSRF token.
  at org.wikipedia.edit.EditClient$1.onResponse(EditClient.java:75)
  at retrofit2.ExecutorCallAdapterFactory$ExecutorCallbackCall$1$1.run(ExecutorCallAdapterFactory.java:68)
  at android.os.Handler.handleCallback(Handler.java:746)
  at android.os.Handler.dispatchMessage(Handler.java:95)
  at android.os.Looper.loop(Looper.java:148)
  at android.app.ActivityThread.main(ActivityThread.java:5491)
  at java.lang.reflect.Method.invoke(Native Method)
  at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:728)
  at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:618)

Good news: logging out and back in again fixed it.

I'm going to leave this open for now just so we discuss it next time triage comes around.

Mholloway lowered the priority of this task from High to Medium.Jan 11 2017, 7:40 AM