Page MenuHomePhabricator
Create Task
Maniphest T155057

Graph: First parameter must either be an object or the name of an existing class
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Spotted in production:

Warning: First parameter must either be an object or the name of an existing class in /srv/mediawiki/php-1.29.0-wmf.7/extensions/Graph/includes/ApiGraph.php on line 163

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Graphmaster+0 -3Remove AdHocDebug from master branch
mediawiki/extensions/Graphwmf/1.29.0-wmf.8+3 -0Add logging of pages with broken data
mediawiki/extensions/Graphmaster+3 -0Add logging of pages with broken data
mediawiki/extensions/Graphmaster+1 -1Fix warning in production
Customize query in gerrit

Related Objects

Event Timeline

demon created this task.Jan 10 2017, 10:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 10 2017, 10:11 PM
demon moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.Jan 10 2017, 10:51 PM
gerritbot added a subscriber: gerritbot.Jan 11 2017, 11:56 PM

Change 331801 had a related patch set uploaded (by MaxSem):
Fix warning in production

https://gerrit.wikimedia.org/r/331801

gerritbot added a project: Patch-For-Review.Jan 11 2017, 11:56 PM
gerritbot added a comment.Jan 12 2017, 12:02 AM

Change 331801 merged by jenkins-bot:
Fix warning in production

https://gerrit.wikimedia.org/r/331801

MaxSem closed this task as Resolved.Jan 12 2017, 12:03 AM
MaxSem claimed this task.
ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)).Jan 12 2017, 1:00 AM
Stashbot added a subscriber: Stashbot.Jan 12 2017, 10:08 PM

Mentioned in SAL (#wikimedia-operations) [2017-01-12T22:08:50Z] <maxsem@tin> Synchronized php-1.29.0-wmf.7/extensions/Graph/includes/ApiGraph.php: Debug for T155057 (duration: 00m 38s)

debt added a project: Maps-Sprint.Jan 17 2017, 4:50 PM
debt moved this task from Backlog to Done on the Maps-Sprint board.
MaxSem reopened this task as Open.Jan 17 2017, 10:03 PM

We've had a spike of these warnings, need to investigate deeper.

debt moved this task from Done to In progress on the Maps-Sprint board.Jan 17 2017, 10:14 PM
gerritbot added a comment.Jan 18 2017, 11:53 PM

Change 332913 had a related patch set uploaded (by MaxSem):
Add logging of pages with broken data

https://gerrit.wikimedia.org/r/332913

gerritbot added a comment.Jan 19 2017, 12:06 AM

Change 332913 merged by jenkins-bot:
Add logging of pages with broken data

https://gerrit.wikimedia.org/r/332913

gerritbot added a comment.Jan 19 2017, 12:06 AM

Change 332916 had a related patch set uploaded (by MaxSem):
Add logging of pages with broken data

https://gerrit.wikimedia.org/r/332916

gerritbot added a comment.Jan 19 2017, 12:16 AM

Change 332916 merged by jenkins-bot:
Add logging of pages with broken data

https://gerrit.wikimedia.org/r/332916

debt moved this task from In progress to Done on the Maps-Sprint board.Jan 19 2017, 12:21 AM
ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-24_(1.29.0-wmf.9)).Jan 19 2017, 1:00 AM
MaxSem moved this task from Done to In progress on the Maps-Sprint board.Jan 20 2017, 6:35 PM
MaxSem closed this task as Resolved.Jan 20 2017, 10:59 PM

Upon reading logs generated by the above change, the conclusion that this is data truncation at https://ru.wikipedia.org/wiki/User:MaxBioHazard/pageview_peaks and the solution is T119043: Graph/Graphoid/Kartographer - data storage architecture. Current error suppressing plug is justified, logging code will stay for now until we resolve the storage problem. This can be closed.

gerritbot added a comment.Oct 27 2018, 11:08 PM

Change 470221 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/Graph@master] Remove AdHocDebug from master branch

https://gerrit.wikimedia.org/r/470221

gerritbot removed a project: MW-1.29-release (WMF-deploy-2017-01-24_(1.29.0-wmf.9)).Oct 27 2018, 11:08 PM
gerritbot added a comment.Oct 27 2018, 11:24 PM

Change 470221 merged by jenkins-bot:
[mediawiki/extensions/Graph@master] Remove AdHocDebug from master branch

https://gerrit.wikimedia.org/r/470221

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.2; 2018-10-30).Oct 28 2018, 12:00 AM
Reedy removed a project: Patch-For-Review.May 17 2019, 9:47 PM
mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:11 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL