Page MenuHomePhabricator

ApiSandbox doesn't respect ApiBase::PARAM_ALLOW_DUPLICATES
Closed, ResolvedPublic

Description

For example, the expiry parameter to action=protect takes one expiry timestamp per protections, and it's entirely possible that someone would want to apply the same expiry to more than one protection. The API itself handles this fine, but the CapsuleMultiSelectWidget used in ApiSandbox does not allow this to be entered.

This will require a flag to OO.ui.CapsuleMultiSelectWidget to enable this behavior when it is needed.

Event Timeline

Anomie created this task.Jan 11 2017, 8:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 11 2017, 8:32 PM

Change 331679 had a related patch set uploaded (by Anomie):
CapsuleMultiSelectWidget: Add allowDuplicates option

https://gerrit.wikimedia.org/r/331679

Change 331680 had a related patch set uploaded (by Anomie):
ApiSandbox: Honor ApiBase::PARAM_ALLOW_DUPLICATES flag

https://gerrit.wikimedia.org/r/331680

Anomie moved this task from Unsorted to Needs Review on the MediaWiki-API board.Jan 11 2017, 8:48 PM

Change 331679 merged by jenkins-bot:
CapsuleMultiSelectWidget: Add allowDuplicates option

https://gerrit.wikimedia.org/r/331679

Change 331680 merged by jenkins-bot:
ApiSandbox: Honor ApiBase::PARAM_ALLOW_DUPLICATES flag

https://gerrit.wikimedia.org/r/331680

Anomie closed this task as Resolved.Jan 11 2017, 9:22 PM
Jdforrester-WMF moved this task from Backlog to OOjs-UI-0.18.4 on the OOUI board.Jan 18 2017, 1:17 AM
Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.18.4); removed OOUI.