Page MenuHomePhabricator
Create Task
Maniphest T155166

ArticlePlaceholder stalls
Closed, ResolvedPublic
Actions

Description

While working on a GCI task I stumbled across a bug in ArticlePlaceholder where running "Translate article" stalls forever.

Steps to reproduce:

  1. Open https://eo.wikipedia.org/wiki/Special:AboutTopic?uselang=en
  2. Insert Q12345 and click craft
  3. Scroll down and click on "Krei artikolon"
  4. Click on "Translate article"
  5. Click "Ek"
  6. Wait as it stalls for an eternity

I've reproduced it in Firefox 50.1.0 and Chrome 55.0.2883.87 on Fedora 25

Details

SubjectRepoBranchLines +/-
Add a name to CreateArticleDialog.mediawiki/extensions/ArticlePlaceholdermaster+3 -1
Customize query in gerrit

Related Objects

Event Timeline

SacredWKnight created this task.Jan 12 2017, 12:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 12 2017, 12:55 PM
SacredWKnight added a project: ArticlePlaceholder.Jan 12 2017, 12:57 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptJan 12 2017, 12:57 PM
Aklapper added a comment.Jan 12 2017, 2:34 PM

Wait as it stalls for an eternity

Hmm, cannot reproduce, page loads fine here (Firefox 51, Fedora 24).
Anything in the console of the developer tools of your web browser? (Please see Firefox ≥24; Google Chrome.)

• iecetcwcpggwqpgciazwvzpfjpwomjxn subscribed.Jan 12 2017, 8:51 PM
This comment was removed by • iecetcwcpggwqpgciazwvzpfjpwomjxn.
• iecetcwcpggwqpgciazwvzpfjpwomjxn added a comment.Jan 12 2017, 8:53 PM
This comment was removed by • iecetcwcpggwqpgciazwvzpfjpwomjxn.
hoo moved this task from Incoming to Backlog on the ArticlePlaceholder board.Jan 31 2017, 3:02 PM
hoo added subscribers: Lydia_Pintscher, Lucie, hoo.
Tgr subscribed.Feb 19 2017, 10:31 PM

See T149807: WindowManager should not let you add windows with no name defined.

gerritbot subscribed.Apr 3 2017, 3:23 PM

Change 346167 had a related patch set uploaded (by Hoo man):
[mediawiki/extensions/ArticlePlaceholder@master] Add a name to CreateArticleDialog.

https://gerrit.wikimedia.org/r/346167

gerritbot added a project: Patch-For-Review.Apr 3 2017, 3:23 PM
hoo claimed this task.Apr 3 2017, 3:24 PM
hoo moved this task from Backlog to Review on the ArticlePlaceholder board.
hoo added a project: Wikidata-Former-Sprint-Board.
hoo moved this task from Proposed to Review on the Wikidata-Former-Sprint-Board board.
gerritbot added a comment.Apr 4 2017, 4:06 PM

Change 346167 merged by Hoo man:
[mediawiki/extensions/ArticlePlaceholder@master] Add a name to CreateArticleDialog.

https://gerrit.wikimedia.org/r/346167

hoo closed this task as Resolved.Apr 4 2017, 4:07 PM
hoo moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.
hoo moved this task from Review to Done on the ArticlePlaceholder board.
hoo removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL