disallowBlankTranslations banana rule is enforced although empty translations can be valid
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Umherirrender
	Jan 12 2017, 5:58 PM

Description

https://gerrit.wikimedia.org/r/#/c/331689/ exports a json with empty message keys, breaking banana tests

17:15:30 Running "banana:Material" (banana) task
17:15:30 >> The "ext" translation has 2 blank translations:
17:15:30 >> The translation of "material-desc" is blank.
17:15:30 >> The translation of "material-guest" is blank.
17:15:30 Warning: Task "banana:Material" failed. Use --force to continue.

The export script should ignore empty message keys, empty means here after trim and also with nbsp (the real one, not  ), because with T155160 a non-empty string was detected.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Skip blank translation on export	mediawiki/extensions/Translate	master	+11 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Declined	None	T91707 L10n-bot should not force-merge / override Jenkins (breaks the build)
Open	None	T93591 Tasks blocking translatewiki.net / l10n-bot patch sets from merging
Open	None	T155182 disallowBlankTranslations banana rule is enforced although empty translations can be valid

Event Timeline

Umherirrender created this task.Jan 12 2017, 5:58 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 12 2017, 5:58 PM

Umherirrender added a parent task: T93591: Tasks blocking translatewiki.net / l10n-bot patch sets from merging.Jan 12 2017, 5:58 PM

The two messages are empty because they were created in the wrong language, moved and then blanked:

Creating blank pages is also possible, per T59238: MediaWiki should not prevent creation of empty pages (I just confirmed on https://translatewiki.net/wiki/MediaWiki:Premoderation-success/la ).

Liuxinyu970226 subscribed.Feb 1 2017, 2:35 PM

Change 361213 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/Translate@master] Skip blank translation on export

https://gerrit.wikimedia.org/r/361213

gerritbot added a project: Patch-For-Review.Jun 24 2017, 2:29 PM

In T155182#3376335, @gerritbot wrote:

Change 361213 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/Translate@master] Skip blank translation on export

This appears to be an incorrect "solution". Blank messages can be correct translations, see T59238#611638.

Change 361213 abandoned by Umherirrender:
Skip blank translation on export

Reason:
per comment

https://gerrit.wikimedia.org/r/361213

Than the default of disallowBlankTranslations in banana is wrong or not useful for use in mediawiki.

Umherirrender removed a project: Patch-For-Review.Jun 24 2017, 9:24 PM

Umherirrender added subscribers: Nikerabbit, Raymond, siebrand.

Krinkle moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board.Jul 7 2017, 5:09 AM

So change disallowBlankTranslations in banana and release a new version and use it everywhere?
Or set it to false in each repository using banana >= 0.3.0

It was set back in 0.3.0 with [1]
The also changed disallowDuplicateTranslations and disallowUnusedTranslations are already reverted back to false in 0.4.0 [2][3]

[1] https://github.com/wikimedia/grunt-banana-checker/commit/e4f495a7dc78ba1df135ad26ae60c538b96f003e
[2] https://github.com/wikimedia/grunt-banana-checker/commit/a9d3aaddc3df9b9f933340d55d0b337a12964eae
[3] https://github.com/wikimedia/grunt-banana-checker/commit/71880f9b7da060518abb388194fdbb9de90e6334

Nemo_bis renamed this task from l10n-bot/translatewiki.net should not export messages not matching banana rules (empty keys) to disallowBlankTranslations banana rule is enforced although empty translations can be valid.Oct 15 2017, 7:27 PM

Nemo_bis edited projects, added I18n; removed translatewiki.net.

Umherirrender mentioned this in T258381: l10n-bot may export empty translations to Git, making banana tests fail.Jul 20 2020, 4:46 PM

Umherirrender mentioned this in T260187: Let banana check for trailing spaces (whitespace + newline) to improve translations from translatewiki.net.Aug 12 2020, 8:39 AM

Umherirrender unsubscribed.Mar 15 2022, 9:55 PM

Jdforrester-WMF added a project: banana-checker.May 20 2023, 11:09 AM

Nikerabbit merged a task: T394652: i18n updates via L10n-bot from translatewiki can contain invalid entries..May 19 2025, 2:04 PM

Nikerabbit added subscribers: Michael, Amire80.

A_smart_kitten mentioned this in T394681: Should banana-checker tests be added to gate-and-submit-l10n?.May 19 2025, 2:41 PM

Cyndymediawiksim subscribed.May 19 2025, 3:23 PM