Page MenuHomePhabricator

OOUI directional icons should have prefixes for semantics and organization
Open, LowestPublic

Description

In the indicators section of https://doc.wikimedia.org/oojs-ui/master/demos/#icons-mediawiki-ltr-desktop (or https://doc.wikimedia.org/oojs-ui/master/demos/#icons-mediawiki-ltr-mobile if you're on mobile viewing this ticket), some icons should be renamed and prefixed for semantics.

In Indicators section:

  • Down -> CaretDown
  • Next -> CaretNext
  • Previous -> CaretPrevious
  • Up -> CaretUp

In "Icons - movement":

  • arrowLast -> arrowLastLong
  • arrowNext -> arrowNextLong
  • caretLast -> arrowLast
  • caretNext -> arrowNext
  • caretDown -> arrowDown
  • caretUp -> arrowUp

Event Timeline

SamanthaNguyen renamed this task from OOUI caret icons should have prefixes for semantics and organization to OOUI directional icons should have prefixes for semantics and organization.Jan 12 2017, 11:10 PM

Next and previous are deliberately used instead of left & right because they flip in RTL mode.

Next and previous are deliberately used instead of left & right because they flip in RTL mode.

Alright, makes sense, I'll modify the ticket description accordingly.

The inconsistency between caretLast & previous could be fixed, but other than that there's little to be gained from renaming these. (< this was related to the original proposals). I don't feel particularly strongly about how arrows are named other than that they are consistent, and there should be a good reason to rename them to avoid disruption.

Volker_E triaged this task as Lowest priority.Jun 18 2017, 3:30 PM

In the process of T177432 we're going for some of the culminated to be renamed elements like 'arrowLast' to 'arrowPrevious'. Nevertheless, I doubt that 'caretPrevious' is preferable over 'previous', given the needed process of renaming icons in OOUI and that developers/users still have to look up the correct name anyways.

@Volker_E: Sorry, originally when I created this task I thought it would be a nice idea, but thinking about it now I'm aware that it's not very good. I'm fine if you'd like to ultimately decline this task.

@SamanthaNguyen Thanks. I propose to set it to resolved when the 'arrowPrevious' change is in and will summarize that we've only fixed the most confusing naming diversion.