VE: Searching for text directly before italic link will highlight this link, too
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	Schnark
	Jan 13 2017, 9:00 AM

Project Tags

Referenced Files

	F5281231: pasted_file
	Jan 13 2017, 6:07 PM

Subscribers

Description

Steps to reproduce:

Go to https://de.wikipedia.org/wiki/Sylvie_und_Bruno?veaction=edit&section=10.
Search for "Gedichts aus " (including the space).

Expected: Just "Gedichts aus " is highlighted.
Actual: "Gedichts aus Throung the Looking-Glass" is highlighted, including the link directly following.

I can reproduce this with any italic link, but not normal links. Replacing the content shows that the selection is actually correct, just the highlight is too large.

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Update VE core submodule to master (de003cf)	DLynch	mediawiki/extensions/VisualEditor	master	+1 -1
	Update RangeFix from 0.2.2 to 0.2.3	Esanders	VisualEditor/VisualEditor	master	+62 -21

Customize query in gerrit

Related Objects

Mentioned Here: rGVEDde003cf1f7aa: Merge "Update RangeFix from 0.2.2 to 0.2.3"

Event Timeline

Schnark created this task.Jan 13 2017, 9:00 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 13 2017, 9:00 AM

Schnark renamed this task from VE: Searching for text directly before cursive link will highlight this link, too to VE: Searching for text directly before italic link will highlight this link, too.Jan 13 2017, 9:54 AM

Schnark updated the task description. (Show Details)

~~WFM, can you post a screenshot?~~ Works in Chrome, but can reproduce in Firefox.

Without much investigation my guess is that this is a getClientRects bug in Firefox :(

Yup *sigh*

Appears to be only happen when we have nails too.

Change 332007 had a related patch set uploaded (by Esanders):
Update RangeFix from 0.2.2 to 0.2.3

https://gerrit.wikimedia.org/r/332007

gerritbot added a project: Patch-For-Review.Jan 13 2017, 11:38 PM

Change 332007 merged by jenkins-bot:
Update RangeFix from 0.2.2 to 0.2.3

https://gerrit.wikimedia.org/r/332007

Change 331991 had a related patch set uploaded (by Jforrester):
Update VE core submodule to master (de003cf)

https://gerrit.wikimedia.org/r/331991

Jdforrester-WMF closed this task as Resolved.Jan 14 2017, 2:58 AM

Jdforrester-WMF assigned this task to Esanders.

Jdforrester-WMF triaged this task as Medium priority.

Jdforrester-WMF set the point value for this task to 8.

Jdforrester-WMF edited projects, added: VisualEditor-ContentEditable, Browser-Support-Firefox; removed: Patch-For-Review.

Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.

Change 331991 merged by jenkins-bot:
Update VE core submodule to master (de003cf)