Page MenuHomePhabricator
Create Task
Maniphest T155322

PictureGame admin panel: Pressing delete or reinstate should ask for confirmation before performing the action
Closed, ResolvedPublic
Actions

Description

After clicking one of these, it'll automatically do whatever action you pressed. They're quite close and thus, easy to accidentally click one of them. Deleting is also a destructive action and reinstating say, an inappropriate-submitted picture game isn't wanted, so it should ask for the person to confirm and acknowledge what kind of action they're performing before it's actually performed.

Details

SubjectRepoBranchLines +/-
Added confirmation dialogs to 'Un-flag' and 'Delete' actions in admin panelmediawiki/extensions/PictureGamemaster+49 -13
Customize query in gerrit

Related Objects

Event Timeline

SamanthaNguyen created this task.Jan 14 2017, 8:49 PM
SamanthaNguyen moved this task from Backlog to Feature Request on the PictureGame board.
SamanthaNguyen updated the task description. (Show Details)
SamanthaNguyen mentioned this in T155324: QuizGame admin panel: Pressing delete or reinstate should ask for confirmation before performing the action.Jan 14 2017, 8:52 PM
Filip claimed this task.Jan 16 2017, 9:01 PM
Filip added a comment.Jan 19 2017, 7:03 PM

@SamanthaNguyen: Only T155324 needs review, and will implement this code here.

SamanthaNguyen added a comment.Jan 19 2017, 7:04 PM

I'll try to review the patch later today, I currently don't have access to my laptop right now

SamanthaNguyen added a comment.Jan 19 2017, 10:03 PM

@FilipGCI - have access now but only for a little bit since I'm busy :) Check out out my comments on the patch

Filip added a comment.EditedJan 20 2017, 5:41 PM

@SamanthaNguyen : T155324 is resolved - will implement this here now.

gerritbot subscribed.Jan 20 2017, 6:38 PM

Change 333283 had a related patch set uploaded (by Filip):
Added confirmation dialogs to 'Un-flag' and 'Delete' actions in admin panel

https://gerrit.wikimedia.org/r/333283

gerritbot added a project: Patch-For-Review.Jan 20 2017, 6:38 PM
gerritbot added a comment.Jan 21 2017, 6:24 PM

Change 333283 merged by jenkins-bot:
Added confirmation dialogs to 'Un-flag' and 'Delete' actions in admin panel

https://gerrit.wikimedia.org/r/333283

SamanthaNguyen closed this task as Resolved.Jan 21 2017, 6:33 PM
SamanthaNguyen removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL