Page MenuHomePhabricator

Consider merging QuizGame, PictureGame, and PollNY extensions together
Open, Needs TriagePublic

Description

NOTE: This will take a ton of work!

There seems to be a lot of code duplication between the three extensions. So, crazy idea: Perhaps these could be merged eventually? I'm not sure what the new name would be: WikiGames/WikiGame maybe? A new configuration could be introduced as well which could be called something like $wgWikiGamesEnable, which excepts an array.

An example where all the games are enabled:

LocalSettings.php
$wgWikiGamesEnable = array(
	'PollNY' => true,
	'PictureGame' => true,
	'QuizGame' => true,
	
);

Event Timeline

SamanthaNguyen moved this task from Unsorted to Combine / Incorporate on the Technical-Debt board.
SamanthaNguyen moved this task from Backlog to Feedback on the PictureGame board.
SamanthaNguyen moved this task from Backlog to Feedback on the QuizGame board.
SamanthaNguyen updated the task description. (Show Details)
SamanthaNguyen renamed this task from Consider merging QuizGame and PictureGame extensions together to Consider merging QuizGame, PictureGame, and PollNY extensions together .Jan 15 2017, 4:58 PM
SamanthaNguyen added a project: PollNY.
SamanthaNguyen updated the task description. (Show Details)
SamanthaNguyen moved this task from Backlog to Feedback on the PollNY board.Jan 23 2017, 2:14 AM
Filip added a subscriber: Filip.Jan 31 2017, 7:30 PM

@SamanthaNguyen : I have an idea. Maybe lets merge PictureGame into QuizGame? QuizGame have better code, it uses api instead of calls to special page, etc.
Maybe, we will just have to choose between 'Create Quiz question', and 'Create Picture question'? Will create git repo, and post my WIP in the future.

Filip added a comment.Jan 31 2017, 7:30 PM

We can convert this to OOjsUI in the same time

@Filip What about PollNY? I already have an idea about merging interfaces and what A special page such as Special:CreateGame would look like too, so I'll submit my idea too sometime this week (maybe even today if I have enough time) and we can combine best of both our ideas into one, what do you think? :-) Also at the OOUI part: There'd already be quite a bit of refactoring, and converting to OOUI is technically a different task. I believe we should do it after.

Filip added a comment.Jan 31 2017, 7:50 PM

@SamanthaNguyen: Thats exactly what I wanted to do. Great! Maybe, instead of doing patches for QuizGame - lets make git repo for it / Thats a big change, working on it in git pull requests would be helpful.

Filip added a comment.EditedJan 31 2017, 7:56 PM

@SamanthaNguyen: PollNY its a bit diffrent extension - Lets merge -games first.

The other thing are databases - games have slightly diffrent tables. We need to create mysql update script, or keep them as-is