Page MenuHomePhabricator

Remove 3D box-shadow for flat element PanelLayout and harmonize inner padding
Closed, ResolvedPublic

Description

In alignment with M101 spatial visual element box-shadow: 0 0.15em 0 0 rgba( 0, 0, 0, 0.15 ) shouldn't be used for fieldset element. It should only just used on elements like dialogs, dropdown menus, tooltips or the VE toolbar.
Together with this proposed change we'll also harmonize padding of oo-ui-panelLayout-padded. The legend element visually isn't providing the same vertical padding on top versus bottom due to the line-height of the legend element.

BeforeAfter
T155335 Bot passwords - Wikipedia 2017-01-14.png (766×339 px, 60 KB)
T155335 Bot passwords - Wikipedia 2017-01-14 _after.png (762×335 px, 59 KB)

Expected outcome:

  • Remove box-shadow and
  • harmonize padding by reducing it at top when legend is visible.

Event Timeline

Change 332118 had a related patch set uploaded (by VolkerE):
PanelLayout: Remove 3D appearance & harmonize padding

https://gerrit.wikimedia.org/r/332118

Can you screenshot the before and after impacts on VisualEditor? PanelLayout is used in DiffDialog, TableDialog, CommandHelpDialog, TableDialog, MWTransclusionDialog, MWGalleryDialog, MWMediaDialog, MWSaveDialog, and FragmentInspector (so pretty much everything).

@Jdforrester-WMF The good part is, that patch is just affecting PanelLayout-framed (.oo-ui-panelLayout.oo-ui-panelLayout-framed) and therefore doesn't affect VE dialogs, which are non-framed PanelLayouts. Should the commit message be updated accordingly?

@Jdforrester-WMF The good part is, that patch is just affecting PanelLayout-framed (.oo-ui-panelLayout.oo-ui-panelLayout-framed) and therefore doesn't affect VE dialogs, which are non-framed PanelLayouts. Should the commit message be updated accordingly?

Oh, I see. Sure, I'll update and merge.

Change 332118 merged by jenkins-bot:
PanelLayout: Remove 3D appearance of framed panels and harmonise padding

https://gerrit.wikimedia.org/r/332118

Volker_E removed a project: Patch-For-Review.
Volker_E moved this task from Backlog to OOjs-UI-0.18.4 on the OOUI board.
Volker_E edited projects, added: OOUI (OOjs-UI-0.18.4); removed: OOUI.