Page MenuHomePhabricator

Android app is hitting the action API "too-many-titles-for-query" deprecation warning
Closed, ResolvedPublic

Description

Over the past 7 days, there have been around 99419 hits on the "too-many-titles-for-query" deprecation warning from user agents starting with "WikipediaApp", for example "WikipediaApp/2.4.184-r-2016-12-14 (Android 6.0.1; Phone) Google Play". For those with access to Kibana, see this dashboard.

For most users,[1] a maximum of 50 titles may be specified for the titles parameter. Titles in excess of 50 are ignored with a warning, although someday I'd like to make that an error. If you have more than 50 titles to query, you should query them in batches. This limit applies to other multi-valued parameters as well.

The queries being made seem to mostly resemble action=query&format=json&titles=...&continue=&prop=pageimages%7Cpageterms&piprop=thumbnail&pithumbsize=320&pilimit=...

[1]: Users with the apihighlimits right have a limit of 500 rather than 50.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Mholloway subscribed.

Reopening per T155393#2982310. This is a separate issue, not a duplicate.

Change 337508 had a related patch set uploaded (by Mholloway):
Retrofit ReadingListPageInfoTask and update caller to query in batches

https://gerrit.wikimedia.org/r/337508

Change 337508 merged by jenkins-bot:
[apps/android/wikipedia] Retrofit ReadingListPageInfoTask and update caller to query in batches

https://gerrit.wikimedia.org/r/337508

Looking at the kibana dashboard linked in the description, I'm still seeing hits to this warning from agents such as "WikipediaApp/2.5.191-r-2017-03-31 (Android 7.0; Phone) Google Play". Does the 2017-03-31 version not include the fix merged on 2017-03-15?

Sorry, not yet. The release on 2017-03-31 was a hotfix update that just contained one cherry-picked critical fix. Our next production release (within the next week or so) will contain the fix in this task.

Ok, I was just checking in case the 2017-03-31 version did contain the patch but it somehow didn't (completely) fix the bug.

Just checked the dashboard and confirmed the latest release isn't showing up in the logs.