Page MenuHomePhabricator
Create Task
Maniphest T155696

Replace Article::doEditContent() with WikiPage::doEditContent()
Closed, ResolvedPublic
Actions

Description

Article::doEditContent() is just a thin wrapper for WikiPage::doEditContent()

It is already hard deprecated, but the following extensions have uses that still need to be replaced:

  • extensions / BlueSpiceFoundation
  • extensions / SocialProfile
  • extensions / BlueSpiceGroupManager
  • extensions / MassEditRegex
  • extensions / OfflineImportLexicon
  • extensions / SemanticImageAnnotator

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+2 -21Remove Article::doEditContent, deprecated and unused
mediawiki/extensions/NewUserMessagemaster+1 -1Update comment to reference WikiPage instead of Article
mediawiki/extensions/Newslettermaster+0 -0Update comment to reference WikiPage instead of Article
mediawiki/extensions/BlueSpiceFoundationmaster+6 -7Replace Article::doEditContent with WikiPage::doEditContent
mediawiki/extensions/SocialProfilemaster+7 -7Replace Article::doEditContent with WikiPage::doEditContent
mediawiki/extensions/SemanticImageAnnotatormaster+1 -2Replace Article::doEditContent with WikiPage::doEditContent
mediawiki/extensions/MassEditRegexmaster+5 -3Replace Article::doEditContent with WikiPage::doEditContent
mediawiki/extensions/BlueSpiceGroupManagermaster+17 -5Replace Article::doEditContent with WikiPage::doEditContent
mediawiki/extensions/OfflineImportLexiconmaster+8 -7Remove global $wgUser, replace Article::doEditContent with WikiPage
mediawiki/coremaster+3 -0Mark Article::doEditContent() as deprecated
Customize query in gerrit

Related Objects

Event Timeline

Reedy created this task.Jan 19 2017, 2:53 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 19 2017, 2:53 AM
gerritbot added a subscriber: gerritbot.Jan 19 2017, 2:57 AM

Change 332936 had a related patch set uploaded (by Reedy):
Mark Article::doEditContent() as deprecated

https://gerrit.wikimedia.org/r/332936

gerritbot added a project: Patch-For-Review.Jan 19 2017, 2:57 AM
gerritbot added a comment.Jan 19 2017, 3:52 AM

Change 332936 merged by jenkins-bot:
Mark Article::doEditContent() as deprecated

https://gerrit.wikimedia.org/r/332936

Reedy removed a project: Patch-For-Review.Jan 19 2017, 3:54 AM
Reedy moved this task from Unsorted to Migrate / Replace on the Technical-Debt board.
ReleaseTaggerBot added projects: MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-01-24_(1.29.0-wmf.9)).Jan 19 2017, 4:00 AM
Krinkle removed projects: MW-1.29-release (WMF-deploy-2017-01-24_(1.29.0-wmf.9)), MW-1.29-release-notes.May 25 2017, 2:00 PM
Jdforrester-WMF mentioned this in T204863: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.32 release.Sep 19 2018, 8:13 PM
Jdforrester-WMF mentioned this in T205029: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.33 release.Oct 11 2018, 8:09 PM
xSavitar closed this task as Resolved.Jan 21 2019, 2:37 PM
xSavitar assigned this task to Reedy.
xSavitar added a subscriber: xSavitar.

This can be resolved as I do not find this anywhere anymore via CS: https://codesearch.wmflabs.org/search/?q=Article%3A%3AdoEditContent&i=nope&files=&repos= apart from a comment in NewUserMessage.class.php and obviously, the history.

Jdforrester-WMF mentioned this in T220656: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.34 release.Apr 10 2019, 8:19 PM
Jdforrester-WMF mentioned this in T232864: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release.Sep 13 2019, 5:33 PM
Daimona reopened this task as Open.Jan 9 2020, 10:48 AM
Daimona added a subscriber: Daimona.
In T155696#4896650, @D3r1ck01 wrote:

This can be resolved as I do not find this anywhere anymore via CS: https://codesearch.wmflabs.org/search/?q=Article%3A%3AdoEditContent&i=nope&files=&repos= apart from a comment in NewUserMessage.class.php and obviously, the history.

This is not enough, because the method is not static. I'm fairly confident that there are other uses outside of WMF-deployed stuff. For instance, here.

DannyS712 added a parent task: T242935: Deprecate core fallbacks to $wgUser.Jan 26 2020, 8:48 AM
DannyS712 added a subscriber: DannyS712.Jan 26 2020, 9:16 AM

Since the functions have the same names, searching for the ->doEditContent\( returns both the old and the new, and call each needs to be checked:
To fix

  • extensions / BlueSpiceFoundation
  • extensions / SocialProfile
  • extensions / BlueSpiceGroupManager
  • extensions / MassEditRegex
  • extensions / OfflineImportLexicon
  • extensions / SemanticImageAnnotator

No remaining article calls:

* Core
* extensions / Translate
* extensions / Wikibase
* extensions / Flow
* extensions / MassMessage
* edwardspec / mediawiki-moderation
* extensions / Echo
* extensions / CentralNotice
* extensions / Jade
* extensions / LiquidThreads
* extensions / SecurePoll
* extensions / WebDAV
* JeroenDeDauw / Maps
* SemanticMediaWiki / SemanticMediaWiki
* extensions / DynamicPageList
* extensions / FlaggedRevs
* extensions / Genealogy
* extensions / PageForms
* extensions / PageSchemas
* JeroenDeDauw / SubPageList
* examknow / CentralCheckUser
* extensions / Athena
* extensions / AutoCreateCategoryPages
* extensions / Babel
* extensions / BlogPage
* extensions / BlueSpiceChecklist
* extensions / BlueSpiceSMWConnector
* extensions / BlueSpiceSocialTopics
* extensions / CheckUser
* extensions / CloneDiff
* extensions / CommentStreams
* extensions / ConfirmAccount
* extensions / CreatedPagesList
* extensions / CreateRedirect
* extensions / CreateUserPage
* extensions / DataTransfer
* extensions / DisplayTitle
* extensions / FanBoxes
* extensions / FileImporter
* extensions / Form
* extensions / GWToolset
* extensions / HAWelcome
* extensions / LinkFilter
* extensions / MintyDocs
* extensions / MissedPages
* extensions / NewsTicker
* extensions / NewUserMessage
* extensions / OracleTextSearch
* extensions / ORES
* extensions / PageTriage
* extensions / Patroller
* extensions / PhabTaskGraph
* extensions / PhpTagsStorage
* extensions / PollNY
* extensions / PrivateDomains
* extensions / ReplaceText
* extensions / Scribunto
* extensions / SpamBlacklist
* extensions / SpamDiffTool
* extensions / SplitPrivateWiki
* extensions / TemplateStyles
* extensions / Thanks
* extensions / TranslateSvg
* extensions / UploadWizard
* extensions / Video
* extensions / WikiLexicalData
* extensions / WikimediaMaintenance
* extensions / Wikispeech
* femiwiki / Sanctions
* hexmode / mediawiki-PeriodicRelatedChanges
* lingua-libre / RecordWizard
* miraheze / CreateWiki
* mkroetzsch / AutoCreatePage
* Nikerabbit / mediawiki-extensions-Nimiarkisto
* Nikerabbit / mediawiki-extensions-Sanat
* Nikerabbit / mediawiki-extensions-Termbank
* Nikerabbit / mediawiki-extensions-WordNet
* SemanticMediaWiki / SemanticTasks
* Wikifab / AutoSetPageLang
* wikiworksdev / CloneDiff

Codesearch: https://codesearch.wmflabs.org/search/?q=-%3EdoEditContent%5C(&i=nope&files=%5C.php%24&repos=

gerritbot added a comment.Jan 26 2020, 10:29 AM

Change 564170 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/OfflineImportLexicon@master] Remove global $wgUser, replace Article::doEditContent with WikiPage

https://gerrit.wikimedia.org/r/564170

gerritbot added a project: Patch-For-Review.Jan 26 2020, 10:29 AM
DannyS712 added a project: User-DannyS712.Jan 26 2020, 10:29 AM
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.
DannyS712 claimed this task.Jan 28 2020, 5:17 PM
DannyS712 updated the task description. (Show Details)Feb 13 2020, 5:27 AM
gerritbot added a comment.Feb 17 2020, 11:42 AM

Change 564170 merged by jenkins-bot:
[mediawiki/extensions/OfflineImportLexicon@master] Remove global $wgUser, replace Article::doEditContent with WikiPage

https://gerrit.wikimedia.org/r/564170

DannyS712 mentioned this in rEOIL34f670092e1e: Remove global $wgUser, replace Article::doEditContent with WikiPage.Feb 17 2020, 11:43 AM
gerritbot added a comment.Feb 19 2020, 12:58 AM

Change 573037 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/SemanticImageAnnotator@master] Replace Article::doEditContent with WikiPage::doEditContent

https://gerrit.wikimedia.org/r/573037

gerritbot added a comment.Feb 19 2020, 12:59 AM

Change 573038 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MassEditRegex@master] Replace Article::doEditContent with WikiPage::doEditContent

https://gerrit.wikimedia.org/r/573038

gerritbot added a comment.Feb 19 2020, 1:00 AM

Change 573039 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/BlueSpiceGroupManager@master] Replace Article::doEditContent with WikiPage::doEditContent

https://gerrit.wikimedia.org/r/573039

gerritbot added a comment.Feb 19 2020, 1:01 AM

Change 573040 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/SocialProfile@master] Replace Article::doEditContent with WikiPage::doEditContent

https://gerrit.wikimedia.org/r/573040

gerritbot added a comment.Feb 19 2020, 1:03 AM

Change 573041 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/BlueSpiceFoundation@master] Replace Article::doEditContent with WikiPage::doEditContent

https://gerrit.wikimedia.org/r/573041

DannyS712 removed a parent task: T242935: Deprecate core fallbacks to $wgUser.Feb 19 2020, 1:10 AM

The actual use of $wgUser is in WikiPage::doEditContent

gerritbot added a comment.Feb 19 2020, 1:46 AM

Change 573039 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceGroupManager@master] Replace Article::doEditContent with WikiPage::doEditContent

https://gerrit.wikimedia.org/r/573039

DannyS712 updated the task description. (Show Details)Feb 19 2020, 3:26 AM
DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.
gerritbot added a comment.Feb 19 2020, 4:20 AM

Change 573038 merged by jenkins-bot:
[mediawiki/extensions/MassEditRegex@master] Replace Article::doEditContent with WikiPage::doEditContent

https://gerrit.wikimedia.org/r/573038

gerritbot added a comment.Feb 19 2020, 4:40 AM

Change 573037 merged by jenkins-bot:
[mediawiki/extensions/SemanticImageAnnotator@master] Replace Article::doEditContent with WikiPage::doEditContent

https://gerrit.wikimedia.org/r/573037

DannyS712 updated the task description. (Show Details)Feb 19 2020, 4:41 AM
gerritbot added a comment.Feb 19 2020, 4:48 AM

Change 573040 merged by Ppchelko:
[mediawiki/extensions/SocialProfile@master] Replace Article::doEditContent with WikiPage::doEditContent

https://gerrit.wikimedia.org/r/573040

gerritbot added a comment.Feb 19 2020, 4:49 AM

Change 573041 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceFoundation@master] Replace Article::doEditContent with WikiPage::doEditContent

https://gerrit.wikimedia.org/r/573041

DannyS712 mentioned this in rESPRd9e489b5f947: Replace Article::doEditContent with WikiPage::doEditContent.Feb 19 2020, 4:51 AM
DannyS712 updated the task description. (Show Details)Feb 19 2020, 5:26 AM
gerritbot added a comment.Feb 19 2020, 5:30 AM

Change 573067 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove Article::doEditContent, deprecated and unused

https://gerrit.wikimedia.org/r/573067

gerritbot added a comment.Feb 19 2020, 8:10 PM

Change 573363 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Newsletter@master] Update comment to reference WikiPage instead of Article

https://gerrit.wikimedia.org/r/573363

gerritbot added a comment.Feb 19 2020, 8:10 PM

Change 573363 abandoned by DannyS712:
Update comment to reference WikiPage instead of Article

Reason:
Wrong repo :(

https://gerrit.wikimedia.org/r/573363

gerritbot added a comment.Feb 19 2020, 8:11 PM

Change 573364 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/NewUserMessage@master] Update comment to reference WikiPage instead of Article

https://gerrit.wikimedia.org/r/573364

gerritbot added a comment.Feb 19 2020, 8:25 PM

Change 573364 merged by jenkins-bot:
[mediawiki/extensions/NewUserMessage@master] Update comment to reference WikiPage instead of Article

https://gerrit.wikimedia.org/r/573364

gerritbot added a comment.Feb 19 2020, 8:30 PM

Change 573067 merged by jenkins-bot:
[mediawiki/core@master] Remove Article::doEditContent, deprecated and unused

https://gerrit.wikimedia.org/r/573067

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.21; 2020-02-25).Feb 19 2020, 9:00 PM
DannyS712 closed this task as Resolved.Feb 19 2020, 9:39 PM
DannyS712 removed a project: Patch-For-Review.
DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.Feb 23 2020, 10:22 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL