Page MenuHomePhabricator

Intederminate ProgressBar isn't behaving correctly in RTL
Closed, ResolvedPublic

Description

The indeterminate ProgressBar has a wrong animation in RTL.

Event Timeline

As a workaround you could define a [dir=rtl] .myClass {} selector?

Have submitted https://github.com/cssjanus/cssjanus/pull/45 which solves the issue locally. Will need to port to PHP once merged.

Ok, so there's the technical issue. I also wanna make sure that we're not having an internationalization issue either.
Timeline/timely progression showing graphs are ltr in Hebrew to my knowledge. Example of stock graphs: http://www.tase.co.il/heb/Pages/Homepage.aspx?fullsite=1

@Amire80 @Mooeypoo Could you shed some light here, would a progress bar be expected or seen more correct in a certain direction?

Ok, so there's the technical issue. I also wanna make sure that we're not having an internationalization issue either.
Timeline/timely progression showing graphs are ltr in Hebrew to my knowledge. Example of stock graphs: http://www.tase.co.il/heb/Pages/Homepage.aspx?fullsite=1

@Amire80 @Mooeypoo Could you shed some light here, would a progress bar be expected or seen more correct in a certain direction?

Yeah, some graphs would be LTR because when we do math, we work LTR, but for some it makes sense to be RTL, depending on contexts. If the context is numerical, it makes sense to leave the graph LTR most times, but if it is purely verbal (like bar graph with groups that have a name) then you usually see RTL.

In this case, the bar indicates "progress" and I can make the case that it goes from "beginning to end" -- which would mean it should be right to left in RTL context.

However, seeing as video files, for instance, still show left-to-right progress (mostly due to historical devices like VHS and such, that went ltr regardless of content) I can also make a case for having the progress bar show as left-to-right.

I'm not sure what to answer. I personally think we should go with RTL sliding, because it makes sense with the direction of the loaded UI, but I also don't think it's a crucial urgent bug to fix in case there are technical constraints.

@Amire80 may have more to say on this.

By the way - while in Hebrew, math goes LTR which makes sense why a graph would be LTR, that is not true for all RTL languages, which should be another reason to flip the progress bar. Languages whose numbers are also RTL may well have everything RTL, including graphs, which means the progress bar should definitely be able to flip for those.

In a conversation with @Amire80 today, he second your comments about it working in both directions with –in my understanding– a minor preference for RTL movement, also given other RTL languages. Therefore let's just flip it like originally intended Thanks for all your help!

@Mardetanha or @Ladsgroup, can one of you comment on the above?

@Volker_E, to summarize our conversation outside of this thread today: The math is written LTR in Persian which makes F5313614 not look right to me (I expect the progress bar to be shown from left to right). This being said, Mardetanha and Ladsgroup are in a better position to comment on this.

In a conversation with @Amire80 today, he second your comments about it working in both directions with –in my understanding– a minor preference for RTL movement, also given other RTL languages. Therefore let's just flip it like originally intended Thanks for all your help!

Very minor preference for RTL movement. Or maybe no preference at all.

It's more important:

  • that the direction will be consistent with the direction of the determinate ProgressBar. It can be both LTR or RTL, but it should be the same in both types of bars, and consistent throughout the site.
  • that the movement of the indeterminate ProgressBar will not be —how would I put it?— jumpy. Currently the blue bar appears and disappears strangely in RTL.
Volker_E claimed this task.

This got resolved with latest CSSJanus release (I think 0.3.2) several days ago and is already fixed in the demos. Both bars, determinante and indeterminante, are moving RTL now. If there's any new arguments, please re-open and share.