ApiEchoNotifications deletes all notifications if passed notformat=text
Closed, ResolvedPublic
Actions

Description

If notformat=text is passed to ApiEchoNotifications, it deletes all notifications instead of returning any of them. It does not seem that this is reversible without directly editing the database.

It looks like rECHOcf7100963849: Remove deprecated formatter removed the "legacy" formatter that notformat=text was attempting to use, causing formatting to just fail, and rECHO6e2236db8109: Moderate notifications caused Echo to delete notifications that cannot be formatted.

The best thing may be to just remove the 'text' option if it's no longer supported.

Details

	Subject	Repo	Branch	Lines +/-
	Remove 'text' as a valid notifications output format	mediawiki/extensions/Echo	master	+0 -3

Customize query in gerrit

Related Objects

Mentioned Here: rECHOcf7100963849: Remove deprecated formatter
rECHO6e2236db8109: Moderate notifications

Event Timeline

Anomie created this task.Jan 21 2017, 3:28 AM

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJan 21 2017, 3:28 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Anomie moved this task from Unsorted to Non-core-API stuff on the MediaWiki-Action-API board.Jan 21 2017, 3:28 AM

SBisson claimed this task.Jan 25 2017, 2:57 PM

SBisson edited projects, added Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017); removed Collaboration-Team-Triage.

SBisson moved this task from Untriaged to In Development on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.

Change 334133 had a related patch set uploaded (by Sbisson):
Remove 'text' as a valid notifications output format

https://gerrit.wikimedia.org/r/334133

gerritbot added a project: Patch-For-Review.Jan 25 2017, 3:19 PM

SBisson moved this task from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.Jan 25 2017, 3:19 PM

Change 334133 merged by jenkins-bot:
Remove 'text' as a valid notifications output format

https://gerrit.wikimedia.org/r/334133

SBisson moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.Jan 27 2017, 5:43 PM

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)).Jan 27 2017, 6:00 PM

Anomie moved this task from Non-core-API stuff to Done on the MediaWiki-Action-API board.Jan 27 2017, 6:59 PM

@SBisson

Checking in betalabs:
https://en.wikipedia.beta.wmflabs.org/w/api.php?action=query&meta=notifications&notformat=text, I got the following:

{
    "error": {
        "code": "unknown_notformat",
        "info": "Unrecognized value for parameter \"notformat\": text.",
        "*": "See https://en.wikipedia.beta.wmflabs.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at &lt;https://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce&gt; for notice of API deprecations and breaking changes."
    },
    "servedby": "deployment-mediawiki05"
}

Whereas, 'flyout', /* @deprecated */ and 'html', /* @deprecated */ options provide some helpful information about the deprecated options along with displaying the list of notifications - checked at https://en.wikipedia.beta.wmflabs.org/w/api.php?action=query&meta=notifications&notformat=flyout:

-------
"\"notformat=flyout\" has been deprecated and will be removed soon. Use \"notformat=model\" to get the raw data or \"notformat=special\" for pre-rendered HTML."
        }
    },
    "query": {
        "notifications": {
            "list": [
-----------------

Yep, 'flyout' and 'html' are deprecated but text was completely removed.

QA recommendation: Resolve.

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.Jan 31 2017, 6:43 PM

• jmatazzoni closed this task as Resolved.Jan 31 2017, 6:54 PM

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:39 PM

ApiEchoNotifications deletes all notifications if passed notformat=textClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

ApiEchoNotifications deletes all notifications if passed notformat=text
Closed, ResolvedPublic
Actions