Page MenuHomePhabricator

VE: Link to template description page should open in a new tab
Closed, ResolvedPublic1 Story Points

Description

Steps to reproduce:

  1. Open a page for editing in VE.
  2. Open the dialog to insert a template, enter the name of a template.
  3. There is a short description on the top of the dialog with a link to the template page. Click this link.

Expected: The page opens in a new tab.
Actual: Depending on your preferences a warning is shown that you'll loose all your changes (not that bad, but interrupts workflow), or you go to the template page, really loosing all your changes (really bad, even though you decided to disable that warning).

Details

Related Gerrit Patches:
mediawiki/extensions/VisualEditor : masterUse target=_blank for link in template 'extra description'

Event Timeline

Schnark created this task.Jan 21 2017, 9:04 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptJan 21 2017, 9:04 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 333489 had a related patch set uploaded (by Esanders):
Use target=_blank for link in template 'extra description;

https://gerrit.wikimedia.org/r/333489

Jdforrester-WMF closed this task as Resolved.Jan 25 2017, 12:42 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.

Change 333489 merged by jenkins-bot:
Use target=_blank for link in template 'extra description'

https://gerrit.wikimedia.org/r/333489