Page MenuHomePhabricator
Create Task
Maniphest T155893

Endless loading when pressing "Show preview" (Uncaught TypeError: span.firstChild.getAttribute is not a function)
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps I did:

  1. I went to https://commons.wikimedia.org/w/index.php?title=Category:Cylapus&veaction=editsource (didn't exist yet)
  2. I pasted some content
  3. I pressed the pen icon to switch to VE
  4. I pressed the same icon (this time [[ ]]) to get back to wikitext
  5. I pressed Save page
  6. I pressed Show preview

Result:
Enless loding, and this error message

pasted_file (1,366×768 px, 286 KB)

pasted_file (1,366×768 px, 391 KB)

Uncaught TypeError: span.firstChild.getAttribute is not a function                                 index.php:386
    at isOnPage (eval at <anonymous> (/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1rfuz0b:4), <anonymous>:386:965)
    at createEditors (eval at <anonymous> (/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1rfuz0b:4), <anonymous>:389:169)
    at setup (eval at <anonymous> (/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1rfuz0b:4), <anonymous>:389:379)
    at getPage (eval at <anonymous> (/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1rfuz0b:4), <anonymous>:393:83)
    at really_run (eval at <anonymous> (/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1rfuz0b:4), <anonymous>:394:302)
    at LoadTrigger.register (eval at <anonymous> (/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1rfuz0b:4), <anonymous>:326:520)
    at run (eval at <anonymous> (/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1rfuz0b:4), <anonymous>:393:718)
    at eval (eval at <anonymous> (/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1rfuz0b:4), <anonymous>:396:545)
    at fire (/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1rfuz0b:45)
    at Object.fireWith (/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1rfuz0b:46)

Related Objects

Event Timeline

Josve05a created this task.Jan 21 2017, 2:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 21 2017, 2:51 PM
Josve05a updated the task description. (Show Details)Jan 21 2017, 2:51 PM
Josve05a renamed this task from Endless loading when prressing "Show preview" (Uncaught TypeError: span.firstChild.getAttribute is not a function) to Endless loading when pressing "Show preview" (Uncaught TypeError: span.firstChild.getAttribute is not a function).Jan 21 2017, 2:53 PM
Josve05a moved this task from Backlog to VisualEditor Liaising on the User-Josve05a board.Jan 21 2017, 4:43 PM
Esanders subscribed.Jan 22 2017, 11:23 AM

This is a bug in hotcat, it hooks in to wikipage.content, but doesn't scope its actions to the target element.

Esanders added a project: MediaWiki-extensions-Gadgets.Jan 22 2017, 11:27 AM
Esanders added a comment.Jan 22 2017, 12:09 PM

https://commons.wikimedia.org/w/index.php?title=MediaWiki%3AGadget-HotCat.js&type=revision&diff=230589327&oldid=211134664 Prevents the exception being thrown.

Esanders closed this task as Resolved.Jan 22 2017, 12:09 PM
Esanders claimed this task.
Krenair removed a project: MediaWiki-extensions-Gadgets.Jan 22 2017, 5:35 PM
Krenair mentioned this in T147197: load.php TypeError: span.firstChild.getAttribute (due to HotCat code) when navigating through a PDF's pages.
Krenair merged a task: T154397: Previewing article in NWE stucks when HotCat enabled.Jan 22 2017, 5:38 PM
Krenair added subscribers: Stryn, • matmarex, Jdforrester-WMF, Krenair.
Jdforrester-WMF triaged this task as Medium priority.Jan 26 2017, 2:43 PM
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF set the point value for this task to 1.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits