Page MenuHomePhabricator

Rename ArticleHeaderView to PageHeaderView
Closed, ResolvedPublic

Description

All articles are pages but only some pages are articles. ArticleHeaderView is a misnomer and should be called PageHeaderView. There's a ton of other article misnomers in the code but this task just covers ArticleHeaderView itself and nothing else

Event Timeline

Hi, I am a newcomer to wikimedia-mobile. I would like to do this task, if it is not assigned to anyone else and still needs fixing. I have already built and run the Wikipedia-Android-App in my machine.

I have few questions regarding the task.

  1. There are three files which have "ArticleHeaderView" name. Should the change be reflected on all these files?
    1. ArticleHeaderView.java
    2. ArticleHeaderView_ViewBinding.java
    3. ArticleHeaderViewTest.java
  2. If we Refactor ArticleHeaderView class name, it will not replace the variable names which uses the class name. For example "ArticleHeaderView articleHeaderView" will be changed to "PageHeaderView articleHeaderView". Should the class name change be reflected in the variable names as well?

@Sandaru Feel free to claim this task! To answer your questions:

  • ArticleHeaderView_ViewBinding.java is auto-generated; don't worry about it.
  • Yes, do rename all other occurrences of ArticleHeaderView in class names as well as variable names and layout (xml) names.

Should ArticleHeaderImageView be changed to PageHeaderImageView too?
Apart from Article header view there are other resources like view_article_header_image.xml, strings like article_header_hint , menus like menu_article_header_edit.xml. I should change them too right?

Change 333954 had a related patch set uploaded (by Sandaru):
Rename ArticleHeaderView to PageHeaderView

https://gerrit.wikimedia.org/r/333954

I submitted the changes. Please let me know if anything should be improved or changed.

Change 333954 merged by jenkins-bot:
Rename ArticleHeaderView to PageHeaderView

https://gerrit.wikimedia.org/r/333954

@Sandaru, looks good! Thank you! Please keep up the good work!