Page MenuHomePhabricator
Create Task
Maniphest T155930

Special:Contribution should have javascript highlighting as well
Closed, ResolvedPublic
Actions

Description

Right now it does basic CSS-based highlighting. The javascript is being injected but can't be used due to structural differences of Special:Contributions and Special:RecentChanges.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Rework highlighting frontend to make it work everywheremediawiki/extensions/ORESmaster+18 -18
Customize query in gerrit

Related Objects

Event Timeline

Ladsgroup created this task.Jan 22 2017, 2:23 PM
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJan 22 2017, 2:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Ladsgroup moved this task from Incoming to Blocked on others on the User-Ladsgroup board.Jan 22 2017, 2:24 PM
gerritbot subscribed.Jan 22 2017, 2:25 PM

Change 333497 had a related patch set uploaded (by Ladsgroup):
Add javascript highlighting to Special:Contributions as well

https://gerrit.wikimedia.org/r/333497

gerritbot added a project: Patch-For-Review.Jan 22 2017, 2:25 PM
gerritbot added a comment.Jun 12 2017, 5:46 AM

Change 358311 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/ORES@master] Rework highlighting frontend to make it work everywhere

https://gerrit.wikimedia.org/r/358311

gerritbot added a comment.Jun 22 2017, 10:35 AM

Change 358311 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Rework highlighting frontend to make it work everywhere

https://gerrit.wikimedia.org/r/358311

Ladsgroup moved this task from Review to Completed on the Machine-Learning-Team (Active Tasks) board.Jun 22 2017, 10:37 AM
Halfak mentioned this in Blog Post: Status update (July 11th, 2017).Jul 12 2017, 10:44 PM
Halfak closed this task as Resolved.Jul 12 2017, 10:49 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits