Page MenuHomePhabricator

Incorrect filtering can be applied at individual reading list due to unexpected navigation between single to all reading lists whilst search is active
Closed, ResolvedPublic

Description

Problem
User should not be able to move back to the lists page when searching in a single reading list. Besides the inaccuracy of the navigation paradigm applied, if in the middle of a search, this can also lead to hidden results when the user returns to that single list screen.

Steps to reproduce

  1. Open a reading list that has multiple articles
  2. Tap search and enter a search key so that the list is filtered to only some of the articles
  3. Tap on the second back arrow (*not* on the app bar) to return to the list of Reading lists
  4. Tap on the top back arrow to exit out of search from the reading lists screen
  5. Tap to view the reading list again

Expected
The reading list should show the full list of articles

Actual
The reading list only shows the articles filtered down from the search in step 2.

Reading list bug - exit and return out of search in list.gif (960×540 px, 852 KB)

Event Timeline

Dbrant renamed this task from BUG - Incorrect filtering can be applied at individual reading list due to unexpected navigation between single to all reading lists whilst search is active to Incorrect filtering can be applied at individual reading list due to unexpected navigation between single to all reading lists whilst search is active.Jan 23 2017, 3:00 PM

Change 336862 had a related patch set uploaded (by Mholloway):
Remove back nav button when reading list detail action mode is enabled

https://gerrit.wikimedia.org/r/336862

Change 336862 merged by jenkins-bot:
Remove back nav button when reading list detail action mode is enabled

https://gerrit.wikimedia.org/r/336862

QA: Please ensure that it's impossible to go from the list of reading lists to the detail view for a single list, or vice versa, with results filtered because of text entered in the search bar.

From the list of lists to the list detail, the search action mode should close.

From the list detail to the list of lists, the navigation should be impossible before the action mode is closed.

Testing on Samsung-SM-JI20A Galaxy Express 3 (Android 6.0.1) and Wikipedia app 2.5.189-alpha-2017-02-22. This is fixed according to this video, results are filtered but return to showing the full list upon using arrows/taps to go back to the original full Reading list: