Page MenuHomePhabricator

BUG - When an article is added to a new reading list which is given the same name as an existing list, that article is adding to the existing list
Closed, ResolvedPublic1 Estimated Story Points

Description

If adding an article to a new reading list with the same name as an existing list, article is added to the existing list instead.

Steps to reproduce

  1. Create a list called "My reading list" and add an article to that list
  2. Tap on the bookmark icon on another article and select to add it to a new list.
  3. Ensure the name of the new list is the same as the previous "My reading list" list name.

Expected
Either..
(a) The two articles get saved to two separate lists with the same name (or else 'My reading list' and 'My reading list (1)')
..Or
(b) A prompt appears letting the user know that a list with the same name already exists and prevents them from creating a new list with the same name.

Actual
Both articles have been saved to the same list

Example of bug (open to view animated gif):

Reading lists bug - article added to same list.gif (540×960 px, 1 MB)

Event Timeline

Change 336349 had a related patch set uploaded (by Mholloway):
Prevent user attempting to create a duplicate-titled reading list

https://gerrit.wikimedia.org/r/336349

Change 336349 merged by jenkins-bot:
Prevent user attempting to create a duplicate-titled reading list

https://gerrit.wikimedia.org/r/336349

Testing on Samsung-SM-JI20A Galaxy Express 3 (Android 6.0.1) and Wikipedia app 2.5.189-alpha-2017-02-22. This is fixed, as shown in this screencap my testing device forbids creating a duplicate-titled reading list:

T156017.png (800×480 px, 60 KB)