Page MenuHomePhabricator

Update image request for new license parameter
Closed, ResolvedPublic

Assigned To
None
Authored By
JMinor
Jan 23 2017, 6:31 PM
Referenced Files
F6305385: T156045 Bill Clinton 2.PNG
Mar 7 2017, 10:33 PM
F6305425: T156045 Fair Use 3.PNG
Mar 7 2017, 10:33 PM
F6305254: T156045 Avatar 3.PNG
Mar 7 2017, 10:33 PM
F6305422: T156045 Fair Use 1.PNG
Mar 7 2017, 10:33 PM
F6305423: T156045 Fair Use 2.PNG
Mar 7 2017, 10:33 PM
F6305250: T156045 Avatar 2.PNG
Mar 7 2017, 10:33 PM
F6305387: T156045 Bill Clinton 3.PNG
Mar 7 2017, 10:33 PM
F6305253: T156045 Avatar 4.PNG
Mar 7 2017, 10:33 PM

Description

See linked ticket T152216

Event Timeline

Lets start by enabling pilicense=any for requests to mobile frontend. We may have a second pass with geographic/policy based restrictions for some uses.

JoeWalsh subscribed.

Based on reading the closed/linked ticket (below). I added some testcases to the iOS Test Case document. Mostly checking for pages with mixed free and non-free (Avatar Film 2009) and no free images (Bill Clinton) and all free images (Fair Use). Moving to Need QA.

https://phabricator.wikimedia.org/T152216

Hi @JMinor is it possible to write a series of steps presenting a scenario I can recreate and if I need a specific iOS device to do it on? That would help me to contribute.

@Nicholas.tsg - These are the tests I've added to the testcases document. Hopefully, this helps:

  1. Search for Avatar (film 2009). View the image in the search result. Tap the article. Tap the lead image. Scroll images. Verify both free and non-free images appear.
  2. Search for Bill Clinton. View the image in the search result. Tap the article. Tap the lead image. Scroll images. Verify both free and non-free images appear.
  3. Search for Fair Use. View the image in the search result. Tap the article. Tap the lead image. Scroll images. Verify both free and non-free images appear.

As mentioned earlier: checking for pages with mixed free and non-free (Avatar Film 2009) and no free images (Bill Clinton) and all free images (Fair Use)

Testing on iPhone 7 (iOS 10.2) and Wikipedia app 5.4.0 (1084). Tests seem to be fixed and working as expected.

In Step 1, both free and non-free images appear for the Avatar page:

T156045 Avatar 1.PNG (1×750 px, 471 KB)
T156045 Avatar 2.PNG (1×750 px, 792 KB)
T156045 Avatar 3.PNG (1×750 px, 3 MB)
T156045 Avatar 4.PNG (1×750 px, 1 MB)
T156045 Avatar 5.PNG (1×750 px, 1 MB)

In Step 2, both free (copyright with slash thru it) and non-free? (Creative Commons) images appear for the Bill Clinton page:

T156045 Bill Clinton 1.PNG (1×750 px, 382 KB)
T156045 Bill Clinton 2.PNG (1×750 px, 963 KB)
T156045 Bill Clinton 3.PNG (1×750 px, 3 MB)
T156045 Bill Clinton 4.PNG (1×750 px, 2 MB)

In Step 3, the Fair Use page is all free images as expected:

T156045 Fair Use 1.PNG (1×750 px, 324 KB)
T156045 Fair Use 2.PNG (1×750 px, 681 KB)
T156045 Fair Use 3.PNG (1×750 px, 2 MB)
T156045 Fair Use 4.PNG (1×750 px, 550 KB)