There's some files that aren't being used, they should be removed accordingly.
Description
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
v4.1.3 - remove unused legacy files from source repo | mediawiki/skins/Truglass | master | +1 -3 |
Event Timeline
Change 333841 had a related patch set uploaded (by SamanthaNguyen):
v4.1.3 - remove unused legacy files from source repo
Change 333841 merged by jenkins-bot:
v4.1.3 - remove unused legacy files from source repo
good first task tasks are self-contained, non-controversial issues with a clear approach and should be well-described with pointers to help the new contributor. Given the short task description I'm removing the good first task tag as a new contributor cannot find out which files are "unused legacy".
Granted, the task description isn't the most verbose one out there, but I disagree with your conclusion. By simply using [[https://en.wikipedia.org/wiki/Grep|grep]] anyone could've figured out whether an image (or a CSS file, etc.) was used by the skin or not. If grepping for a particular file name resulted in no matches, then the file is probably unused. Of course like with a bunch of other things, there can be some weird edge cases and whatnot, but that's what we have the code review process for -- so that a more experienced dev can go through the proposed changes and approve 'em or suggest modifications.
If you have heard of grep or if it's available on your OS: Yes. Such info is welcome in future task descriptions if they are supposed to be "easy". :)