Update gerrit to 2.14.6
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Paladox
	Jan 24 2017, 11:05 AM

Description

Gerrit 2.14 has been released now and also 2.14.1 has been released with a ton of bug fixes over 70+ and now also 2.14.2 with other 90+ bug fixes including one big bug fix we need.

The release notes are at https://www.gerritcodereview.com/releases/2.14.md

https://www.gerritcodereview.com/releases/2.14.md#2.14.1

https://www.gerritcodereview.com/releases/2.14.md#2.14.2

https://www.gerritcodereview.com/releases/2.14.md#2.14.3

https://www.gerritcodereview.com/releases/2.14.md#2.14.4

https://www.gerritcodereview.com/releases/2.14.md#2.14.5

https://www.gerritcodereview.com/releases/2.14.md#2.14.5.1

https://www.gerritcodereview.com/releases/2.14.md#2.14.6

Main features / bug fixes:

You can get external id's through the rest api.

Requires java 8+ now.

Bouncy castle is no longer needed as a external dep. it is now installed into the war so no need to download it anymore.

Load external IDs from primary storage (ReviewDb). Fixes T152640 (partially, full fix will be in 2.16 / 3.0)

Buck has been replace with bazel, see https://gerrit-review.googlesource.com/Documentation/dev-bazel.html

We will need to update our it's-phabricator plugin for this update see T156024 . This includes some important upgrades like introduction of closure compiler (soy) replacing velocity.

Also this release will support elasticsearch along side lucene. (this is experimental and does not yet work with elasticsearch 5.x+)

They have added support for soy template and deprecated the other template we use for our mail template in gerrit.

PolyGerrit will now be accessible through a cookie. PolyGerrit is enabled by default but not default ui. (Works on prefixed urls and works on https://gerrit.git.wmflabs.org/r/?polygerrit=1)

Emails are now sent in html format by default instead of the old default of plain text. (Though this can be disabled in your preference if you want).

ssh-eddsa is now supported which means a more securer code review server. https://gerrit-review.googlesource.com/#/c/100998/ (though there was a bug that actually prevented this from working, Fix was released upstream and is included in gerrit 2.15+)

The ability to delete your own changes (open or abandoned) if you have the permission to do so and for admins to delete any open or abandoned changes.

You can now create tags through the web ui like you can with branches.

You can now set a assignee for changes.

Details

Subject	Repo	Branch	Lines +/-
Gerrit 2.14.6	operations/software/gerrit	master	+9 -9
Gerrit: Set gc.auto and gc.autopacklimit to 0 in ~/.gitconfig	operations/puppet	production	+11 -0
Gerrit: Add some apache rewrite rules for polygerrit	operations/puppet	production	+22 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Tgr	T152801 "index-pack failed" when installing new MediaWiki-Vagrant box
Resolved	Paladox	T153079 Merge/Submit error on Gerrit: "org.eclipse.jgit.errors.MissingObjectException: Missing unknown" for BlueSpiceExtensions' REL1_27 branch
Resolved	• demon	T151676 gerrit jgit gc caused mediawiki/core repo problems
Resolved	None	T48776 Add 'reply' button to Gerrit comments that quotes the original comment
Resolved	None	T48777 "add comment" feature doesn't allow you to write a comment while viewing the code or viewing the other comments
Resolved	Paladox	T161206 Gerrit patchset 99101 cannot be accessed: "500 Internal server error"
Resolved	Paladox	T146361 In changeset view, clicking the "Owner" name does not display list of their changesets but of unrelated other user
Resolved	Paladox	T153085 Gerrit doesn't display committed images
Declined	None	T158915 Setup reply emails for gerrit
Resolved	• demon	T158008 Gerrit: Convert Velocity templates to Closure Templates
Resolved	Paladox	T156024 Convert its-phabricator upstream repo which wmf maintains to bazel
Declined	None	T38471 Gerrit needs a very wide screen or has big horizontal scroll
Resolved	Paladox	T168590 Change Gerrit's default indentation to tabs
Resolved	None	T168030 Enable Gerrit feature to add comment when people add reviewers to a patch
Resolved	hashar	T48148 Allow hiding of non-discussion comments in Gerrit
Resolved	• demon	T152640 Cannot log into Gerrit as of recent upgrade
Resolved	None	T174551 Data loss: Click "Reply...", enter text, open a diff, have your text lost
Resolved	Paladox	T140366 @gerritbot probably allows users to make arbitrary changes to Phabricator tasks by submitting crafted Gerrit changesets
Resolved	Paladox	T178385 Replace using certificates with tokens when using its-phabricator
Resolved	• demon	T156120 Update gerrit to 2.14.6
Open	None	T184086 Add prometheus exporter to Gerrit
Resolved	• demon	T184116 Setup gitiles for use with gerrit as a repo viewer

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

@hashar and @Volans ED25519 note that the key may be buggy in gerrit 2.14.1 see this bug, https://bugs.chromium.org/p/gerrit/issues/detail?id=6504 but depends on the client i think connecting to it. so on the mac it worked for me.

But luckily there's a fix upstream in apache mina sshd (they need to do a release for gerrit to be updated).

@Paladox FYI I'm still getting Invalid SSH Key when trying to add my key

@Volans yep, that will go when we upgrade. Tested on https://gerrit.git.wmflabs.org/r/ when adding ED25519 key.

Paladox mentioned this in T161206: Gerrit patchset 99101 cannot be accessed: "500 Internal server error".Jun 14 2017, 1:33 PM

Paladox added a subtask: T161206: Gerrit patchset 99101 cannot be accessed: "500 Internal server error".

Aklapper removed a subtask: T161206: Gerrit patchset 99101 cannot be accessed: "500 Internal server error".Jun 14 2017, 4:10 PM

Aklapper added a parent task: T161206: Gerrit patchset 99101 cannot be accessed: "500 Internal server error".

Paladox removed a subtask: T158243: Update zuul to latest pre 3.0 commit.Jun 14 2017, 4:15 PM

Paladox added a parent task: T158243: Update zuul to latest pre 3.0 commit.

Paladox removed a subtask: T146361: In changeset view, clicking the "Owner" name does not display list of their changesets but of unrelated other user.

Paladox added a parent task: T146361: In changeset view, clicking the "Owner" name does not display list of their changesets but of unrelated other user.

Paladox removed a subtask: T153085: Gerrit doesn't display committed images.

Paladox added a parent task: T153085: Gerrit doesn't display committed images.

Paladox removed a subtask: T158915: Setup reply emails for gerrit.

Paladox added a parent task: T158915: Setup reply emails for gerrit.

Paladox removed a subtask: T158008: Gerrit: Convert Velocity templates to Closure Templates .

Paladox added a parent task: T158008: Gerrit: Convert Velocity templates to Closure Templates .

Volans unsubscribed.Jun 14 2017, 4:17 PM

Paladox removed a subtask: T156024: Convert its-phabricator upstream repo which wmf maintains to bazel.Jun 14 2017, 4:17 PM

Paladox added a parent task: T156024: Convert its-phabricator upstream repo which wmf maintains to bazel.

Paladox removed a subtask: T38471: Gerrit needs a very wide screen or has big horizontal scroll.

Paladox added a parent task: T38471: Gerrit needs a very wide screen or has big horizontal scroll.

Paladox added a parent task: T168030: Enable Gerrit feature to add comment when people add reviewers to a patch.Jun 16 2017, 8:57 AM

Peachey88 removed a parent task: T168030: Enable Gerrit feature to add comment when people add reviewers to a patch.Jun 16 2017, 9:03 AM

Peachey88 added a subtask: T168030: Enable Gerrit feature to add comment when people add reviewers to a patch.

Paladox added a parent task: T168590: Change Gerrit's default indentation to tabs.Jul 2 2017, 5:45 PM

Paladox removed a subtask: T168030: Enable Gerrit feature to add comment when people add reviewers to a patch.

Paladox added a parent task: T168030: Enable Gerrit feature to add comment when people add reviewers to a patch.

Paladox removed subtasks: T159744: Gerrit: inline edit references are not updated, T159743: Gerrit: can lose data if it crashes, T158479: Decide how to support polygerrit.Jul 2 2017, 5:47 PM

@Peachey88 T168030 is parent to this task because the feature is in gerrit 2.14 (polygerrit (new ui)) (which means that we have to update to 2.14 to gain that feature.)

Paladox added a parent task: T48148: Allow hiding of non-discussion comments in Gerrit.Jul 4 2017, 2:44 PM

ed25519 key is now fixed in 1.6.0 which has just been released. I will see if i can get this back ported to 2.14.2. if not it will be in 2.15.

Paladox added a comment.Jul 5 2017, 1:26 PM

This comment was removed by Paladox.

Paladox added a parent task: T152640: Cannot log into Gerrit as of recent upgrade.Jul 14 2017, 4:48 PM

2.14.2 will be released tomorrow. Will update the description tomorrow. :)

Paladox renamed this task from Update gerrit to 2.14.1 to Update gerrit to 2.14.2.Jul 19 2017, 1:20 AM

Paladox updated the task description. (Show Details)

Paladox updated the task description. (Show Details)Jul 19 2017, 1:24 AM

Upstream won't merge the sshd patch that includes the fix for edcsa so we will need to either cherry pick it when we build or wait until 2.15.

Paladox renamed this task from Update gerrit to 2.14.2 to Update gerrit to 2.14.3.Aug 24 2017, 2:02 AM

Paladox updated the task description. (Show Details)

Paladox updated the task description. (Show Details)Aug 24 2017, 2:40 PM

Paladox added a parent task: T48777: "add comment" feature doesn't allow you to write a comment while viewing the code or viewing the other comments.Aug 26 2017, 11:37 AM

Paladox added a parent task: T174551: Data loss: Click "Reply...", enter text, open a diff, have your text lost.Aug 30 2017, 2:50 PM

Paladox removed a parent task: T158243: Update zuul to latest pre 3.0 commit.Aug 31 2017, 9:12 AM

Paladox added a subtask: T158243: Update zuul to latest pre 3.0 commit.

Changing priority to match new task added.

Paladox renamed this task from Update gerrit to 2.14.3 to Update gerrit to 2.14.4.Sep 21 2017, 6:24 AM

Paladox updated the task description. (Show Details)

Gerrit 2.14 should be stable by now :).

there should now be less updates to 2.14 as 2.15 rc has been released.

Mentioned in SAL (#wikimedia-cloud) [2017-10-12T19:34:40Z] <paladox> preparing gerrit-test3 for the gerrit 2.14 update. testing 2.13 -> 2.14 update for T156120