Page MenuHomePhabricator
Create Task
Maniphest T156164

RCFilters UI: Use mixins and variables in Less files
Closed, ResolvedPublic
Actions

Description

The current ess files use hexadecimal values for the colors in the prototype. We need to change those to Less variables, as they are repeating throughout the UI.

It would be best to use the existing color scheme, see

  • M82 Color palette (Wikimedia Design Style Guide/WikimediaUI)
    17
    • (source: https://phabricator.wikimedia.org/M82)

    It would be great if we could use the proposed built-in Less variables but they don't seem to be in core just yet (see https://github.com/wikimedia/WikimediaUI-Base)

    Instead, we should just make sure all the repeated color values are defined as Less variables and then used in the definitions.

    Details

    Related Gerrit Patches:
    mediawiki/core : masterRCFilters: Use mixins and variables in LESS files
    mediawiki/core : masterRCFilters UI: Highlight behavior

    Related Objects

    Event Timeline

    Mooeypoo created this task.Jan 24 2017, 7:33 PM
    Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 24 2017, 7:33 PM
    Volker_E renamed this task from RCFilters UI: Use mixins and variables in LESS files to RCFilters UI: Use mixins and variables in Less files.Jan 25 2017, 7:11 AM
    Volker_E updated the task description. (Show Details)
    Volker_E awarded a token.
    Volker_E added a subscriber: Volker_E.
    gerritbot added a subscriber: gerritbot.Feb 23 2017, 6:11 PM

    Change 337048 had a related patch set uploaded (by Mooeypoo):
    RCFilters UI: Highlight behavior

    https://gerrit.wikimedia.org/r/337048

    gerritbot added a comment.Feb 23 2017, 7:41 PM

    Change 337048 merged by jenkins-bot:
    RCFilters UI: Highlight behavior

    https://gerrit.wikimedia.org/r/337048

    Catrope added a subscriber: Catrope.Feb 23 2017, 10:19 PM

    @Mooeypoo Despite the tagged patch, this isn't done yet, right?

    Mooeypoo moved this task from In Development to Blocked on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.Feb 24 2017, 1:07 AM

    @Catrope so, this is half done as in we now have mixins and variables -- the ones that I was referring to are for the MW stylesheet, but I am waiting for @Volker_E to update his variables file (this one https://phabricator.wikimedia.org/source/wikimedia-ui-base/browse/master/wmui-base.less ) so we can perhaps use that.
    Otherwise, we'll have to duplicate all that data and then keep it updated when colors/variations change, which is not ideal.

    Of course, the even better ideal is if that file would be merged into core -- or could be offered as its own module -- so that we won't have to manually update it either, but we'll start with, at the very least, the upcoming standard.

    I'm moving it to "blocked".

    Volker_E added a comment.Feb 24 2017, 9:29 PM

    @Mooeypoo The most recent update of WikimediaUI Base files is captured in https://phabricator.wikimedia.org/D576 – after it get's merged, I'll push tag 0.8.0.

    SBisson removed Mooeypoo as the assignee of this task.Oct 5 2017, 1:12 PM
    SBisson moved this task from Blocked to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
    SBisson added a subscriber: SBisson.

    It looks like this is ready to be worked on.

    @Mooeypoo I unassigned you so it's available for other people (Petar, for instance) but feel free to claim it back if you really want to do it.

    gerritbot added a comment.Oct 10 2017, 1:59 PM

    Change 383358 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
    [mediawiki/core@master] RCFilters: Use mixins and variables in Less files

    https://gerrit.wikimedia.org/r/383358

    gerritbot added a comment.Oct 16 2017, 1:45 PM

    Change 383358 merged by jenkins-bot:
    [mediawiki/core@master] RCFilters: Use mixins and variables in LESS files

    https://gerrit.wikimedia.org/r/383358

    Etonkovidova added a subscriber: Etonkovidova.Oct 17 2017, 10:35 PM

    Checked the highlight color functionality in testwiki (wmf.4) - no regression; works as expected.

    Etonkovidova closed this task as Resolved.Oct 17 2017, 10:39 PM
    Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL