Page MenuHomePhabricator

[mobile] The wikitext button (the switch) is present and displayed as active in mobile view
Open, Needs TriagePublic

Description

Note: Desktop view does not have the issue with switching to VE

  1. Open a Flow board on mediawiki (or you can use betalabs).
  2. Click to post a reply - and click on the '[[ ]]' icon to switch to VE.

Switching to VE is not possible.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 24 2017, 10:57 PM
SBisson added a subscriber: SBisson.EditedJan 25 2017, 9:29 PM

Did VisualEditor in Flow on mobile ever worked? mw.flow.ui.VisualEditorWidget.js seems to say no.

	mw.flow.ui.VisualEditorWidget.static.isSupported = function () {
		var isMobileTarget = ( mw.config.get( 'skin' ) === 'minerva' );

		/* global VisualEditorSupportCheck */
		return !!(
			!isMobileTarget &&
			mw.loader.getState( 'ext.visualEditor.core' ) &&
			mw.config.get( 'wgFlowEditorList' ).indexOf( 'visualeditor' ) !== -1 &&
			window.VisualEditorSupportCheck && VisualEditorSupportCheck()
		);
	};

ping @MSchottlender-WMF , @Catrope , @Mattflaschen-WMF

@SBisson VE is working for Flow posts in desktop mode.

@SBisson VE is working for Flow posts in desktop mode.

Yes, but the code above indicates that it is explicitly disabled on mobile and it doesn't look like it has changed recently. I'm wondering if anyone has seen it working, ever.

Right.
@SBisson Hmm... It looks like a different issue(usability) now: given the fact that users are almost "arbitrarily" ( the cases documented here: T107108: Flow notification links on mobile point to desktop) get redirected between mobile and desktop views, the availability of VE also looks "arbitrarily". I am removing Regression tags.

Etonkovidova renamed this task from [mobile regression wmf.9] Cannot switch to VE on Flow post to Cannot switch to VE on Flow post in mobile view.Jan 25 2017, 11:18 PM

It may not be a regression but having a "switch to VE" button that doesn't work is still not ideal. We could

  1. Enable VE in Flow on mobile (with all the testing and support involve), or
  2. Remove the "switch to VE" button

I vote for #2 until we have an appetite for #1.

@jmatazzoni thoughts?

@SBisson, I think the right functionality is for this to work the same as desktop. Elena doesn't think it's overly burdensome to do the testing. Are you indicating that implementing #1 is a large task?

@SBisson, I think the right functionality is for this to work the same as desktop. Elena doesn't think it's overly burdensome to do the testing. Are you indicating that implementing #1 is a large task?

Enabling it is a small task but it has the potential to negatively affect performance for a large number of users[1]. We just have to be prepared to explain, fix and support long term like everything else.

[1] This is a guess. I don't know how many Flow users use it on mobile and what are their devices and networks.

In my opinion, there is the option 3. Keep the current behavior(there are no users's complaints). Add the issue to the our list of mobile improvements that we're planning to do.

I've changed the issue title to reflect that the issue is less severe.

Etonkovidova renamed this task from Cannot switch to VE on Flow post in mobile view to [mobile] The wikitext button (the switch) is present and displayed as active in mobile view.Jan 30 2017, 8:12 PM
Jdlrobson moved this task from Needs triage to Triaged on the Mobile board.Jul 25 2017, 5:40 PM
SBisson moved this task from Inbox to Triaged but Future on the Growth-Team board.