Page MenuHomePhabricator

Lead image should not crop to face detection if less than 5% of the entire picture
Closed, ResolvedPublic

Description

IMG_4703.PNG (750×1,334 px, 608 KB)
IMG_4704.PNG (750×1,334 px, 913 KB)

This crop to Mitch McConnell's (turtle) face is not an expectd lead image, since it is only a fraction of the entire "wanted" image.

iOS 10.2.1 beta
Build 1046

Event Timeline

Josve05a updated the task description. (Show Details)
Josve05a added a project: User-Josve05a.
Zppix subscribed.

This is just a simple code change just have it make sure its cropped to the chest-area or like a mug shot type crop perhaps?

cmadeo subscribed.

This sounds like a good solution to me!

@AMroczkowski this is the face detection issue I mentioned at standup.

Per this and the other ticket I think, face detection or no, we should limit the amount of scaling we do with lead images. To solve both, lets limit the scaling of lead images to 2x and then only top align if we do scale.

Lets try that and see a few test cases.

iirc the face detection method gives an array of the faces found with rects. if we compare the area of the largest (1st?) rect we can compare it to the area of the image for this logic

In practice. 25% seemed too high. I cut it down to 5% and it actually seems to before better in practice.

Note, current threshold is 5% not 25% but seems to work in practice

JMinor renamed this task from Lead image should not crop to face detection if less than ~25% of the entire picture to Lead image should not crop to face detection if less than 5% of the entire picture.Feb 24 2017, 9:14 PM
This comment was removed by cmadeo.

This may be one of my favorite tickets ever...

Testing on iPhone 5s (iOS 10.2.1) and Wikipedia app 5.4.0 (1081). According to the below screencaps this is fixed now as the correct lead image is displayed in the article:

T156217 Part 1.PNG (640×1,136 px, 669 KB)

T156217 Part 2.PNG (640×1,136 px, 618 KB)

JMinor claimed this task.

So long turtle face!