Pages with an &stable=1 in their URL could not be viewed or edited
Closed, DuplicatePublic

Description

Pages with an &stable=1 in their URL could not be viewed or edited. See in german wiktionary https://de.wiktionary.org/wiki/Sonne the buttons "Lesen" and "Bearbeiten" don't work.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 26 2017, 10:26 AM
TTO triaged this task as "Unbreak Now!" priority.Jan 26 2017, 10:30 AM
TTO added a project: Operations.
Restricted Application added subscribers: Jay8g, TerraCodes. · View Herald TranscriptJan 26 2017, 10:31 AM
Joe added a subscriber: Joe.Jan 26 2017, 10:33 AM

I can reproduce the problem. Any idea since when is this happening?

TTO added a subscriber: TTO.Jan 26 2017, 10:34 AM

Pages with pending changes (all these: https://de.wiktionary.org/wiki/Spezial:Seiten_mit_ungesichteten_Versionen) can't be edited or read - a totally blank page is returned.

Workaround is probably to review or reject the revisions before editing.

I can reproduce the problem. Any idea since when is this happening?

It obviously isn't broken in wmf.8, otherwise de.wikipedia would be broken, too, which would not go unnoticed. So, it's a bug in wmf.9.

Joe added a comment.Jan 26 2017, 10:41 AM

The error is the following:

Jan 26 10:36:07 mwdebug1001 hhvm: #012Fatal error: Call to undefined method Revision::getText() in /srv/mediawiki/php-1.29.0-wmf.9/extensions/FlaggedRevs/backend/FlaggedRevision.php on line 480

looking into logstash it seems this started yesterday just before 21:00 UTC:

https://logstash.wikimedia.org/goto/a39145089f038f33218fc12e30861194

which corresponds to the SAL entry

20:50 twentyafterfour@tin: rebuilt wikiversions.php and synchronized wikiversions files: group1 wikis to 1.29.0-wmf.9

I think this might be worth a rollback.

Joe added a comment.Jan 26 2017, 10:41 AM

I can reproduce the problem. Any idea since when is this happening?

It obviously isn't broken in wmf.8, otherwise de.wikipedia would be broken, too, which would not go unnoticed. So, it's a bug in wmf.9.

Yes, it is. I was posting my finding and didn't read your comments, thanks :)

Change 334277 had a related patch set uploaded (by Hashar):
Revert "group1 wikis to 1.29.0-wmf.9"

https://gerrit.wikimedia.org/r/334277

Change 334277 merged by jenkins-bot:
Revert "group1 wikis to 1.29.0-wmf.9"

https://gerrit.wikimedia.org/r/334277

Mentioned in SAL (#wikimedia-operations) [2017-01-26T11:12:16Z] <hashar@tin> rebuilt wikiversions.php and synchronized wikiversions files: FlaggedRevs is broken in wmf.9 causing blank pages. T156356 T156310

Joe added a subscriber: hashar.Jan 26 2017, 11:13 AM

@hashar rolled back to wmf.8 and I can confirm the pages I was looking at now render correctly.

From a quick talk on IRC, @Joe recommended to rollback immediately to restore production immediately which is now complete.

https://de.wiktionary.org/w/index.php?title=Sonne&stable=1 works now.

T156310 mentioned that error earlier and there is a straightforward patch to it. Guess I will test it on beta cluster then production group0 and if all is fine move back to wmf.9 when done.

For now marking as a dupe of the other task that has the patch.