VoteNY doesn't round off votes early enough and results in long decimals
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	SamanthaNguyen
	Jan 26 2017, 10:47 PM

Description

And, 4.5 stars gives 4.666666666666667 instead 4.5.

This looks like a good task for Google-Code-in-2017

Hmm, looks like the problem is in Vote.class.php. number_format should do the job.

Its simple task, I can mentor it @Aklapper

Thanks @Filip

@Filip Since you're familiar with this extension, can you add some more details, similar to what people have done in https://phabricator.wikimedia.org/T179691?

@MtDu I'll add some details in GCI task description

To recreate this issue

Create new article with <vote type=1/> inside
Vote for article with votes giving rational number in average
On page Special:TopRatings you can see all ratings, check if this issues still occurs
Fix it (propably by using number_format) send patch to gerrit

Added this task to GCI board.

This issue was fixed.

I tried to recreate this issue, but it was fixed.
Version of plugin: 2.9.2 from 2017-09-21
I voted at four test users.
Ratings: 1,2,5,4

Article view:

Special Page view (Special:TopRatings):

And I tested with one rating, too.

Tested it out, looks like this issue got fixed before. I accepted this task on GCI dashboard

Are you sure it's fixed? @SamanthaNguyen what version was it on at the time?

And your votes haven't done anything that would trigger a recurring number

Yes, I'm sure. I tested many variations of ratings.

	F11069643: image.png
	Nov 29 2017, 4:03 PM

	F11069625: image.png
	Nov 29 2017, 4:03 PM

	F11069681: image.png
	Nov 29 2017, 4:03 PM