Page MenuHomePhabricator

Edit notices icon (ve-ui-mwNoticesPopupTool-items) is empty for new articles
Closed, DuplicatePublic1 Estimated Story Points

Description

When a user attempts to create a new article (and using VE), the 'Edit notices' button when clicked will display an empty
placeholder. Is it a regression or it's an expected behavior? Observed in wmf.8 and wmf.9.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 26 2017, 11:21 PM

It's likely a local wiki issue or with a specific user setup which hides the message with CSS. I think @Krinkle knows how to fix it on the wiki, but I couldn't reproduce it on ca.wiki.

@Esanders The issue is on enwiki and cawiki (wmf.8 and wmf.9); the user does not have any specific setups.

Jdforrester-WMF triaged this task as Medium priority.Feb 14 2017, 8:31 PM
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

This looks like it's fixed for me? @Etonkovidova, can you confirm?

Krinkle added a comment.EditedFeb 25 2017, 12:46 AM

I can't reproduce this on en.wikipedia.org, but on ca.wikipedia.org I can reproduce it on page creations. https://ca.wikipedia.org/wiki/Mavetuna?action=edit

Note however that the first time I opened this url the "Edit notices" bubble didn't open itself as instead "You have switched to visual editing" message shows up (because my account defaults to WikiEditor on cawiki and I had to switch). After closing that message and clicking on the Edit notice button, I got this:

Network inspection shows the API request did provide an edit notice.

Element inspection shows that the edit notice has no content. Not even css-hidden content, which is unlike the typical legacy edit notice system we see (which @Esanders suspected).

Since the switch message seemed unrelated I figured I'd open ve directly by using veaction=edit https://ca.wikipedia.org/wiki/Mavetuna?veaction=edit. Unexpectedly, this actually made the message show up properly.

So I suspect there is a genuine bug in VisualEditor that sometimes causes a real edit notice to not end up inserted into the document for some reason, and as such cause an empty notice to render. Possibly related to another notice ("You switched ..") being shown first.

DLynch added a subscriber: DLynch.Apr 24 2017, 5:05 PM

This reads very much like it's T162812, since explicit mention is made of the switch popup.

Agreed. T153118 is different.