Maniphest T156526

Jenkins is broken on master on extensions enabled BetaFeatures
Closed, ResolvedPublic
Actions

Description

ORES: https://gerrit.wikimedia.org/r/#/c/334695/
Wikibase: https://gerrit.wikimedia.org/r/#/c/334705/

Since no change has been in beta, I think a change in core was cause of this.

Details

	Subject	Repo	Branch	Lines +/-
	Use MutableTestUser in tests	mediawiki/extensions/BetaFeatures	master	+2 -2

Customize query in gerrit

Related Objects

Duplicates Merged Here: T156535: BetaFeatures unit tests failing after change to User::addGroup

Event Timeline

Ladsgroup created this task.Jan 27 2017, 8:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 27 2017, 8:29 PM

Ladsgroup triaged this task as Unbreak Now! priority.Jan 27 2017, 8:30 PM

Restricted Application added subscribers: Jay8g, TerraCodes. · View Herald TranscriptJan 27 2017, 8:30 PM

Paladox subscribed.Jan 27 2017, 8:34 PM

I think the offending change is: https://gerrit.wikimedia.org/r/#/c/328377. Too big to revert. @TTO: Can you check and fix beta features?

Change 334717 had a related patch set uploaded (by Ladsgroup):
Add user to the database

https://gerrit.wikimedia.org/r/334717

gerritbot added a project: Patch-For-Review.Jan 27 2017, 9:23 PM

Paladox edited projects, added Continuous-Integration-Infrastructure, Continuous-Integration-Config; removed Jenkins.Jan 27 2017, 11:19 PM

Paladox merged a task: T156535: BetaFeatures unit tests failing after change to User::addGroup.Jan 27 2017, 11:50 PM

Paladox added subscribers: Jdlrobson, pmiazga.

Sorry about this. Jenkins showed that these tests were failing on Wikibase, so I fixed that extension, but no other failures showed up.

Ricordisamoa subscribed.Jan 28 2017, 7:38 AM

• MZMcBride subscribed.Jan 28 2017, 8:42 AM

Ladsgroup claimed this task.Jan 28 2017, 9:44 AM

Ladsgroup removed a project: Patch-For-Review.

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJan 28 2017, 9:44 AM

Ladsgroup added a project: Wikidata-Former-Sprint-Board.Jan 28 2017, 9:45 AM

Ladsgroup moved this task from Incoming to Done on the User-Ladsgroup board.

Change 334717 merged by jenkins-bot:
Use MutableTestUser in tests

https://gerrit.wikimedia.org/r/334717

Ladsgroup closed this task as Resolved.Jan 28 2017, 9:45 AM

Ladsgroup moved this task from Proposed to Done on the Wikidata-Former-Sprint-Board board.

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)).Jan 28 2017, 10:00 AM