Page MenuHomePhabricator

GRAMMAR doesn't seem to work in https://tools.wmflabs.org/siteviews/url_structure/
Open, Needs TriagePublic

Description

I might be wrong, but I was under the impression that the Pageviews labs tool uses jquery.i18n. If I'm right, then I'd also expect GRAMMAR to work. However, it doesn't seem to work in https://tools.wmflabs.org/siteviews/url_structure/ when I view it in Hebrew.

Event Timeline

Amire80 created this task.Jan 29 2017, 9:47 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 29 2017, 9:47 AM

Pageviews Analysis uses jquery.i18n to load messages as needed, but messages that live in the initial markup are loaded on the backend with Intuition. You have to tell Intuition to parse for magic words, but I actually am doing that here, see https://github.com/MusikAnimal/pageviews/blob/master/views/siteviews/url_structure.haml#L62. So I'm not sure what's going on, maybe a bug? I will try to see if upgrading Intuition will help.

@Amire80 I tried upgrading Intuition and no dice :( The relevant function for Hebrew is here. Does that look like it does what we want? Maybe the "case" we are attempting to use isn't supported.

Amire80 moved this task from Untriaged to Grammar on the I18n board.Mar 1 2018, 4:16 PM

jquery.i18n has grammar support. It will work if the corresponding language has the grammar rules defined. Currently there is a gap in those definitions. The rules defined in LanguageXX.php is not present in the language classes in Javascript