Enabled abusefilters should not be allowed to be marked as deleted. Only disabled filters should.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Don't let enabled filters be marked as deleted | mediawiki/extensions/AbuseFilter | master | +39 -0 |
Event Timeline
Comment Actions
Doing this server-side is pretty straightforward, while client-side this requires a JS listener. That is simple as well, but it's probably better to wait for OOUI and use a hide-if
Comment Actions
The server-side is a must anyway (think about API). But I agree that the client-side would benefit from hide-if
Comment Actions
Yes, indeed. Actually, I'm not sure that we may use hide-if, but anyway OOUI may require different listeners, so let's just wait to do it in one shot.
Comment Actions
Huh, I was actually wrong. Hide-if is from HTMLForm, which I didn't use to build the editing interface. This means that we can already start working on this with standard techniques.
Comment Actions
Change 430414 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Don't let enabled filters be marked as deleted
Comment Actions
Change 430414 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Don't let enabled filters be marked as deleted