Page MenuHomePhabricator
Create Task
Maniphest T156619

Don't allow enabled filters be marked as deleted
Closed, ResolvedPublic
Actions

Description

Enabled abusefilters should not be allowed to be marked as deleted. Only disabled filters should.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/AbuseFiltermaster+39 -0Don't let enabled filters be marked as deleted
Customize query in gerrit

Event Timeline

MarcoAurelio created this task.Jan 30 2017, 9:21 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 30 2017, 9:21 AM
Huji triaged this task as Lowest priority.Sep 2 2017, 3:32 PM
Huji added a project: User-Huji.
Daimona moved this task from Backlog to Management features on the AbuseFilter board.Apr 24 2018, 4:50 PM
Daimona added a subscriber: Daimona.May 1 2018, 7:30 PM

Doing this server-side is pretty straightforward, while client-side this requires a JS listener. That is simple as well, but it's probably better to wait for OOUI and use a hide-if

Huji added a subscriber: Huji.May 1 2018, 7:45 PM

The server-side is a must anyway (think about API). But I agree that the client-side would benefit from hide-if

Daimona added a comment.May 1 2018, 8:44 PM

Yes, indeed. Actually, I'm not sure that we may use hide-if, but anyway OOUI may require different listeners, so let's just wait to do it in one shot.

Daimona added a comment.May 2 2018, 4:23 PM

Huh, I was actually wrong. Hide-if is from HTMLForm, which I didn't use to build the editing interface. This means that we can already start working on this with standard techniques.

gerritbot added a subscriber: gerritbot.May 2 2018, 5:00 PM

Change 430414 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Don't let enabled filters be marked as deleted

https://gerrit.wikimedia.org/r/430414

gerritbot added a project: Patch-For-Review.May 2 2018, 5:01 PM
Daimona claimed this task.May 2 2018, 5:11 PM
Huji closed this task as Resolved.May 2 2018, 10:21 PM
Huji removed projects: Patch-For-Review, User-Huji.
gerritbot added a comment.May 2 2018, 10:27 PM

Change 430414 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Don't let enabled filters be marked as deleted

https://gerrit.wikimedia.org/r/430414

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)).May 2 2018, 11:00 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL