Page MenuHomePhabricator

log events in IRC RC feed not backward compatible/broke bots
Closed, ResolvedPublic

Description

I'm not sure what the format originally was, but it appears that recently the IRC rc feed changed something about its log event messages (I'm guessing made it shorter?), such that it breaks pgkbots and presumably other bots that might be monitoring for uploads, blocks, new user creates, and other logevents (though normal edits seem to be parsed fine). I'd provide more info by jumbling through the source, but I'm not a huge python fan :P

Thanks a million, and cheers =)

--slakr@enwiki


Version: unspecified
Severity: normal

Details

Reference
bz13662

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:08 PM
bzimport set Reference to bz13662.
bzimport added a subscriber: Unknown Object (MLST).

coet.cawiki wrote:

I think that changes break certain parsings. For example, before, in the move log, we can parse the old page and the new page. Now, the new page doesn't appear in the IRC rc message. This situation borrow to make a request to the server to know where the old page redirects.

--Pasqual@cawiki

coet.cawiki wrote:

(In reply to comment #1)

I think that changes break certain parsings. For example, before, in the move
log, we can parse the old page and the new page. Now, the new page doesn't
appear in the IRC rc message. This situation borrow to make a request to the
server to know where the old page redirects.

--Pasqual@cawiki

not ''borrow'', but '''oblige''', '''force'''

Also, a user rights change doesn't include the actual rights that have been changed anymore.
Backwards compatibility isn't as much important to me as the availability of standard data :)

Assigning to Aaron Schultz, I assume it's related to his changes in that area. It would be nice if he could test the IRC output, say by using a test setup that sends data to the debug log instead of UDP. Backwards compatibility most certainly should not be the aim with this particular output format, but it should look nice and give lots of information.

Not at all familiar with this IRC output. Where is the code for this stuff anyway?

bugs wrote:

(In reply to comment #5)

Not at all familiar with this IRC output. Where is the code for this stuff
anyway?

https://wikitech.leuksman.com/view/IRCD might be a good place to start.

I had to fix a upload bot about it:

Old syntax was
[[Special:Log/upload]] upload * <User> * uploaded "[[Image:<Image>]]": <Description>
Now it is:
[[Image:<Image>]] upload * <User> * <Description>

But i think this is the proper way to do it. The first parameter is the target. Those actions on Special:Log only made special cases you needed to treat separatedly.
The bots will obviously need to be updated but it was never a stable interface. You equally need to update when the action upload was splitted into "upload" and "overwrite".

The only desirable thing would be sending an email to wikibots-l when changing the format, so bot authors can prepare the code for next scap.

It wasn't really. Originally it was
<Color>14[[<Color>07Special:Log/upload<Color>14]]<Color>4 upload<Color>10 <Color>02<Color> <Color>5*<Color> <Color>03<User><Color> <Color>5*<Color> <Color>10uploaded "[[<Color>02Image:<Image><Color>10]]": <Description>

Not it is:
<Color>14[[<Color>07Special:Log/upload<Color>14]]<Color>4 upload<Color>10 <Color>02<Color> <Color>5*<Color> <Color>03<User><Color> <Color>5*<Color> <Color>10uploaded "[[Image:<Image>]]": <Description>

Ie. The target filename is no longer blue, which was the handy way to get the action target.