Page MenuHomePhabricator

mediawiki/extensions/UploadWizard "Basic test build" (non-whitelisted users) includes 'jshint', which fails on master, because we switched to eslint
Closed, ResolvedPublic

Description

mediawiki/extensions/UploadWizard "Basic test build" (for non-whitelisted users) includes the 'jshint' job, which currently fails on master, because we switched to ESLint (ran the 'npm-node-6-jessie' job for whitelisted users), in commit 94adbf1db72310ce6ae162c47e079823685139fd. Example failing changeset: https://gerrit.wikimedia.org/r/#/c/334877/1

'jshint' should be removed from the jobs for non-whitelisted users, and if possible, ideally 'npm-node-6-jessie' should be added.

Event Timeline

Change 335082 had a related patch set uploaded (by Hashar):
[UploadWizard] remove built-in jshint/jsonlint

https://gerrit.wikimedia.org/r/335082

Change 335082 merged by jenkins-bot:
[UploadWizard] remove built-in jshint/jsonlint

https://gerrit.wikimedia.org/r/335082

hashar claimed this task.
hashar subscribed.

We will eventually phase out the jshint/jsonlint jobs entirely :]