Page MenuHomePhabricator

Reason feature is not working in Quiz Game extension
Closed, ResolvedPublic

Description

When working on T155451 , I saw that reason feature in Quiz Game is not working. (Looks like typo in QuizGame.js)

Details

Related Gerrit Patches:
mediawiki/extensions/QuizGame : masterFix fatal typo in QuizGame.js

Event Timeline

Filip created this task.Jan 31 2017, 6:01 PM

Change 335260 had a related patch set uploaded (by Filip):
Fix fatal typo in QuizGame.js

https://gerrit.wikimedia.org/r/335260

SamanthaNguyen closed this task as Invalid.Jan 31 2017, 6:58 PM
SamanthaNguyen reassigned this task from Filip to ashley.
SamanthaNguyen removed a project: Patch-For-Review.
SamanthaNguyen added subscribers: ashley, SamanthaNguyen.

@ashley already wrote a patch at https://gerrit.wikimedia.org/r/335173 and merged it into the extension yesterday, so closing this ticket as invalid.

SamanthaNguyen moved this task from Backlog to Bugs on the QuizGame board.Jan 31 2017, 6:58 PM

Change 335260 abandoned by SamanthaNguyen:
Fix fatal typo in QuizGame.js

Reason:
Thank you for your patch, but this was already caught and fixed in https://gerrit.wikimedia.org/r/335173 :-)

https://gerrit.wikimedia.org/r/335260

Filip reopened this task as Open.Jan 31 2017, 7:04 PM

@SamanthaNguyen: Compare both patches. This is not a fix for it.

Filip claimed this task.Jan 31 2017, 7:05 PM

Change 335260 restored by Filip:
Fix fatal typo in QuizGame.js

Reason:
As commented on phab

https://gerrit.wikimedia.org/r/335260

Sorry, I thought this patch said creating a game feature isn't working (I skimmed this ticket too fast) My apologies!

Filip closed this task as Resolved.Feb 4 2017, 9:41 PM

Marking as resolved :)

Change 335260 merged by jenkins-bot:
Fix fatal typo in QuizGame.js

https://gerrit.wikimedia.org/r/335260