Page MenuHomePhabricator
Create Task
Maniphest T156851

scap wikiversions compile happening too late in scap sync
Closed, ResolvedPublic
Actions

Description

On an initial scap sync after a new version is added to wikiversions.json, scap sync is failing to recognize the new version.

This commit is the likely culprit: https://github.com/wikimedia/scap/commit/08af4b9da9763e68588cfeba6c40fb5949a0dc1d

There are two problems:

  1. active_wikiversions is looking at the deploy_dir (i.e., /srv/mediawiki)
  2. sync_common is syncing to the deploy_dir after compile_wikiversions has run

I'm not sure which problem to correct just yet.

Revisions and Commits

rMSCA Scap
Restricted Differential RevisionrMSCAf8c8062a09d3 Explicit sync-common step in mediawiki deploy

Related Objects

Event Timeline

thcipriani created this task.Jan 31 2017, 9:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 31 2017, 9:40 PM
thcipriani triaged this task as High priority.Jan 31 2017, 9:41 PM
thcipriani moved this task from Needs triage to Debt on the Scap board.
bd808 added a subscriber: ori.Jan 31 2017, 10:44 PM

Moving tasks.sync_common after wikiversions-compile certainly would have caused this. Moving the sync before calling wikiversions-compile was fixed in T65659: Scap creates wmf-config/ExtensionMessages-*.php using wikiversions.cdb from prior scap/sync-wikiversions run. See T65659#707930 for an analysis of the old behavior that you have functionally reverted to.

Fun aside, the patch at https://gerrit.wikimedia.org/r/#/c/124627/ was how I earned my I broke Wikipedia... then I fixed it shirt. I love @ori's "..or not" comment posted right after the site melted due to the incorrect logic of deleting the existing file which took the whole farm down.

• mmodell added a comment.Feb 10 2017, 6:07 PM
In T156851#2988199, @bd808 wrote:

Moving tasks.sync_common after wikiversions-compile certainly would have caused this. Moving the sync before calling wikiversions-compile was fixed in T65659: Scap creates wmf-config/ExtensionMessages-*.php using wikiversions.cdb from prior scap/sync-wikiversions run. See T65659#707930 for an analysis of the old behavior that you have functionally reverted to.

Fun aside, the patch at https://gerrit.wikimedia.org/r/#/c/124627/ was how I earned my I broke Wikipedia... then I fixed it shirt. I love @ori's "..or not" comment posted right after the site melted due to the incorrect logic of deleting the existing file which took the whole farm down.

cc: #scap-lore

thcipriani mentioned this in T152005: /srv/mediawiki on tin not being updated when using scap sync-file.Feb 10 2017, 6:15 PM
Stashbot subscribed.Feb 21 2017, 7:17 PM

Mentioned in SAL (#wikimedia-operations) [2017-02-21T19:17:12Z] <demon@tin> Started scap: prime wmf.13 - testwiki plus l10n build (pt 2 because T156851)

thcipriani added a revision: Restricted Differential Revision.Feb 21 2017, 9:40 PM
thcipriani closed this task as Resolved by committing rMSCAf8c8062a09d3: Explicit sync-common step in mediawiki deploy.Feb 27 2017, 4:35 PM
thcipriani added a commit: rMSCAf8c8062a09d3: Explicit sync-common step in mediawiki deploy.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits