scap wikiversions compile happening too late in scap sync
Closed, ResolvedPublic

Description

On an initial scap sync after a new version is added to wikiversions.json, scap sync is failing to recognize the new version.

This commit is the likely culprit: https://github.com/wikimedia/scap/commit/08af4b9da9763e68588cfeba6c40fb5949a0dc1d

There are two problems:

  1. active_wikiversions is looking at the deploy_dir (i.e., /srv/mediawiki)
  2. sync_common is syncing to the deploy_dir after compile_wikiversions has run

I'm not sure which problem to correct just yet.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 31 2017, 9:40 PM
thcipriani triaged this task as "High" priority.Jan 31 2017, 9:41 PM
thcipriani moved this task from Needs triage to Debt on the Scap board.
bd808 added a subscriber: ori.Jan 31 2017, 10:44 PM

Moving tasks.sync_common after wikiversions-compile certainly would have caused this. Moving the sync before calling wikiversions-compile was fixed in T65659: Scap creates wmf-config/ExtensionMessages-*.php using wikiversions.cdb from prior scap/sync-wikiversions run. See T65659#707930 for an analysis of the old behavior that you have functionally reverted to.

Fun aside, the patch at https://gerrit.wikimedia.org/r/#/c/124627/ was how I earned my I broke Wikipedia... then I fixed it shirt. I love @ori's "..or not" comment posted right after the site melted due to the incorrect logic of deleting the existing file which took the whole farm down.

Moving tasks.sync_common after wikiversions-compile certainly would have caused this. Moving the sync before calling wikiversions-compile was fixed in T65659: Scap creates wmf-config/ExtensionMessages-*.php using wikiversions.cdb from prior scap/sync-wikiversions run. See T65659#707930 for an analysis of the old behavior that you have functionally reverted to.

Fun aside, the patch at https://gerrit.wikimedia.org/r/#/c/124627/ was how I earned my I broke Wikipedia... then I fixed it shirt. I love @ori's "..or not" comment posted right after the site melted due to the incorrect logic of deleting the existing file which took the whole farm down.

cc: #scap-lore

Mentioned in SAL (#wikimedia-operations) [2017-02-21T19:17:12Z] <demon@tin> Started scap: prime wmf.13 - testwiki plus l10n build (pt 2 because T156851)