From my understanding, "constructive" is a flag that's deprecated in the MediaWiki theme in favor of "Progressive". (Also stated on https://doc.wikimedia.org/oojs-ui/master/demos/#widgets-mediawiki-ltr next to the constructive ButtonWidget). Although I'm guessing it's still enabled for backwards-compatibility? I'm not sure yet; if someone could clarify that would be greatly appreciated :-)
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| demo: Remove 'Constructive' button from the icons page | oojs/ui | master | +0 -9 |
Related Objects
Related Objects
Event Timeline
Comment Actions
@SamanthaNguyen It is (obviously) confusing and the answer I can provide isn't fully satisfying. Apex theme, which is used by Monobook skin is still using a green for its constructive state.
Comment Actions
As far as I can tell the Apex theme doesn't generate any constructive (or any other, for that matter) variants for icons. So, clicking on Constructive on the demo doesn't show the user anything useful. @SamanthaNguyen has already started the discussion about the flag itself at T156874: The constructive flag in the OOUI Apex theme should be deprecated in favor of the progressive flag, in the meanwhile, I don't see the harm of removing the button.
Comment Actions
Change 335620 had a related patch set uploaded (by Prtksxna):
demo: Remove 'Constructive' button from the icons page
Comment Actions
Change 335620 merged by jenkins-bot:
demo: Remove 'Constructive' button from the icons page