Page MenuHomePhabricator

VE should wait for global.js before init
Closed, ResolvedPublic1 Estimated Story Points

Description

Currently, VE waits with initialization until site and user js has been loaded and executed (function getTarget in ve.init.mw.DesktipArticleTarget.init.js), but not for the global.js from Extension:GlobalCssJs.

Waiting for these modules is necessary to make it possible to define plugins: When VE starts right away (because you opened the page in a new tab, or edited from a non-standard view) these modules only load after VE has started initialization. This currently means that plugins defined in global.js may be missing, because their definition comes too late.

Event Timeline

Schnark created this task.Feb 1 2017, 9:12 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptFeb 1 2017, 9:12 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 335462 had a related patch set uploaded (by DLynch):
DesktopArticleTarget: wait for global.js as well

https://gerrit.wikimedia.org/r/335462

Jdforrester-WMF triaged this task as Low priority.
Jdforrester-WMF added a project: GlobalCssJs.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.

Change 343226 had a related patch set uploaded (by Jforrester):
[mediawiki/extensions/GlobalCssJs] Register our modules as preload requirements for VisualEditor if present

https://gerrit.wikimedia.org/r/343226

Change 335462 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] DesktopArticleTarget: Make the waiting module list extensible

https://gerrit.wikimedia.org/r/335462

Change 343226 merged by jenkins-bot:
[mediawiki/extensions/GlobalCssJs@master] Register our modules as preload requirements for VisualEditor if present

https://gerrit.wikimedia.org/r/343226

Jdforrester-WMF closed this task as Resolved.Mar 28 2017, 4:15 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMar 28 2017, 4:15 PM